[Freeipa-devel] [freeipa PR#373][comment] ipaplatform: Add Debian platform module.

2017-01-19 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/373 Title: #373: ipaplatform: Add Debian platform module. MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/e04b75cb9e71fb2b9faa49aea7f2244b01fddbcb """ See the full comment at https://github.com/freeipa/fr

[Freeipa-devel] [freeipa PR#373][comment] ipaplatform: Add Debian platform module.

2017-01-19 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/373 Title: #373: ipaplatform: Add Debian platform module. stlaz commented: """ The patch seems fine, I could have some nitpicks but nothing really imporant. ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/373#issuecomment-2

[Freeipa-devel] [freeipa PR#373][comment] ipaplatform: Add Debian platform module.

2017-01-19 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/373 Title: #373: ipaplatform: Add Debian platform module. stlaz commented: """ @tiran I would like to test this in a Vagrant box before pushing it """ See the full comment at https://github.com/freeipa/freeipa/pull/373#issuecomment-273796530 -- Man

[Freeipa-devel] [freeipa PR#373][comment] ipaplatform: Add Debian platform module.

2017-01-19 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/373 Title: #373: ipaplatform: Add Debian platform module. stlaz commented: """ @tiran I would like to test this in a Vagrant box before pushing it """ See the full comment at https://github.com/freeipa/freeipa/pull/373#issuecomment-273796530 -- Man

[Freeipa-devel] [freeipa PR#373][comment] ipaplatform: Add Debian platform module.

2017-01-19 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/373 Title: #373: ipaplatform: Add Debian platform module. tiran commented: """ @stlaz the patch looks fine to me now. I can't comment on the path values, though. Do you like to see additional modifications? """ See the full comment at https://githu

[Freeipa-devel] [freeipa PR#373][comment] ipaplatform: Add Debian platform module.

2017-01-11 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/373 Title: #373: ipaplatform: Add Debian platform module. tiran commented: """ pylint is failing: ``` Pylint is running, please wait ... * Module ipaplatform.debian.tasks ipaplatform/debian/tasks.py:10: [E0611(no-name-in-module), ] No name