URL: https://github.com/freeipa/freeipa/pull/400
Title: #400: WebUI: Certificate Mapping
tomaskrizek commented:
"""
master:
* 27027bbc9cf7faa29c3c94686635559cbcbde98a WebUI: Add possibility to set field
always writable
* fba318b83337b71ccb3421690071a130171fbdfe WebUI: Create non editable row
URL: https://github.com/freeipa/freeipa/pull/400
Title: #400: WebUI: Certificate Mapping
pvomacka commented:
"""
@pvoborni Thanks for review. I removed the space :)
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/400#issuecomment-284796053
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/400
Title: #400: WebUI: Certificate Mapping
flo-renaud commented:
"""
Hi @pvomacka
thank you, LGTM.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/400#issuecomment-283923415
--
Manage your subscription for the Freeipa-devel
URL: https://github.com/freeipa/freeipa/pull/400
Title: #400: WebUI: Certificate Mapping
pvomacka commented:
"""
In last update I changed just line 33 in certmap.js file.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/400#issuecomment-283661677
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/400
Title: #400: WebUI: Certificate Mapping
pvomacka commented:
"""
Hi @flo-renaud
Thank you for review.
The issue about certificates is different and here is the fix:
https://github.com/freeipa/freeipa/pull/519
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/400
Title: #400: WebUI: Certificate Mapping
flo-renaud commented:
"""
Hi @pvomacka
Thank you for the updated PR.
I probably wongly advised you to replace 'usercertificate' with 'certificate'
in one extra place where it was not needed, because now
URL: https://github.com/freeipa/freeipa/pull/400
Title: #400: WebUI: Certificate Mapping
pvomacka commented:
"""
Hello @flo-renaud and @pvoborni
thank you for reviews, all proposed changes are done in last commits, please
look at them. Thank you very much.
"""
See the full comment at
