[Freeipa-devel] [freeipa PR#400][comment] WebUI: Certificate Mapping
URL: https://github.com/freeipa/freeipa/pull/400 Title: #400: WebUI: Certificate Mapping tomaskrizek commented: """ master: * 27027bbc9cf7faa29c3c94686635559cbcbde98a WebUI: Add possibility to set field always writable * fba318b83337b71ccb3421690071a130171fbdfe WebUI: Create non editable row widget for mutlivalued widget * d3700275c1b63aeeab13c7dd9e09249bc2c8e4d7 WebUI: Add Custom command multivalued adder dialog * 19426f32ff99feb7c64a4174728cd2b6b946a49a WebUI: Add certmap module """ See the full comment at https://github.com/freeipa/freeipa/pull/400#issuecomment-284988307 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#400][comment] WebUI: Certificate Mapping
URL: https://github.com/freeipa/freeipa/pull/400 Title: #400: WebUI: Certificate Mapping pvomacka commented: """ @pvoborni Thanks for review. I removed the space :) """ See the full comment at https://github.com/freeipa/freeipa/pull/400#issuecomment-284796053 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#400][comment] WebUI: Certificate Mapping
URL: https://github.com/freeipa/freeipa/pull/400 Title: #400: WebUI: Certificate Mapping flo-renaud commented: """ Hi @pvomacka thank you, LGTM. """ See the full comment at https://github.com/freeipa/freeipa/pull/400#issuecomment-283923415 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#400][comment] WebUI: Certificate Mapping
URL: https://github.com/freeipa/freeipa/pull/400 Title: #400: WebUI: Certificate Mapping pvomacka commented: """ In last update I changed just line 33 in certmap.js file. """ See the full comment at https://github.com/freeipa/freeipa/pull/400#issuecomment-283661677 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#400][comment] WebUI: Certificate Mapping
URL: https://github.com/freeipa/freeipa/pull/400 Title: #400: WebUI: Certificate Mapping pvomacka commented: """ Hi @flo-renaud Thank you for review. The issue about certificates is different and here is the fix: https://github.com/freeipa/freeipa/pull/519 """ See the full comment at https://github.com/freeipa/freeipa/pull/400#issuecomment-283045651 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#400][comment] WebUI: Certificate Mapping
URL: https://github.com/freeipa/freeipa/pull/400 Title: #400: WebUI: Certificate Mapping flo-renaud commented: """ Hi @pvomacka Thank you for the updated PR. I probably wongly advised you to replace 'usercertificate' with 'certificate' in one extra place where it was not needed, because now the "Certificates" field of the user details page does not display any more the full certificates. My bad... Apart from that, everything works as expected. Thanks! """ See the full comment at https://github.com/freeipa/freeipa/pull/400#issuecomment-282989454 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#400][comment] WebUI: Certificate Mapping
URL: https://github.com/freeipa/freeipa/pull/400 Title: #400: WebUI: Certificate Mapping pvomacka commented: """ Hello @flo-renaud and @pvoborni thank you for reviews, all proposed changes are done in last commits, please look at them. Thank you very much. """ See the full comment at https://github.com/freeipa/freeipa/pull/400#issuecomment-282792393 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code