URL: https://github.com/freeipa/freeipa/pull/470 Author: pvomacka Title: #470: WebUI: Size limit warning on details pages fixed Action: opened
PR body: """ Entity select fields accepted globally set size limit and in situations when there were more entries than global size limit allows then the "Truncated" warning shows up. Also only subset of items was shown. All entity select widgets now uses find methods with sizelimit set to 0 which says get all entries. This setting is configurable using search_all_entries attribute. https://fedorahosted.org/freeipa/ticket/6618 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/470/head:pr470 git checkout pr470
From 538285dbb7be937ce8eeae88a85d0b918f150911 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Mon, 30 Jan 2017 15:16:41 +0100 Subject: [PATCH] WebUI: Size limit warning on details pages fixed Entity select fields accepted globally set size limit and in situations when there were more entries than global size limit allows then the "Truncated" warning shows up. Also only subset of items was shown. All entity select widgets now uses find methods with sizelimit set to 0 which says get all entries. This setting is configurable using search_all_entries attribute. https://fedorahosted.org/freeipa/ticket/6618 --- install/ui/src/freeipa/widget.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/install/ui/src/freeipa/widget.js b/install/ui/src/freeipa/widget.js index 6ad8aad..2d1d231 100644 --- a/install/ui/src/freeipa/widget.js +++ b/install/ui/src/freeipa/widget.js @@ -5003,6 +5003,8 @@ IPA.entity_select_widget = function(spec) { that.other_entity = IPA.get_entity(spec.other_entity); that.other_field = spec.other_field; that.label_field = spec.label_field || spec.other_field; + that.search_all_entries = spec.search_all_entries === undefined ? true : + spec.search_all_entries; that.options = spec.options || []; that.filter_options = spec.filter_options || {}; @@ -5018,6 +5020,9 @@ IPA.entity_select_widget = function(spec) { if (no_members) { cmd.set_option('no_members', true); } + if (that.search_all_entries) { + cmd.set_option('sizelimit', 0); + } return cmd; };
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
