[Freeipa-devel] [freeipa PR#486][comment] Migrate OTP import script to python-cryptography

2017-02-26 Thread stlaz
  URL: https://github.com/freeipa/freeipa/pull/486
Title: #486: Migrate OTP import script to python-cryptography

stlaz commented:
"""
Fixed in https://github.com/freeipa/freeipa/issues/509
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/486#issuecomment-282643547
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#486][comment] Migrate OTP import script to python-cryptography

2017-02-20 Thread stlaz
  URL: https://github.com/freeipa/freeipa/pull/486
Title: #486: Migrate OTP import script to python-cryptography

stlaz commented:
"""
Thanks for the patch, less `nss` is always good. It seems that 
python-cryptography might have added the `backend` attribute to some 
constructors since the patch was created, our tests found two of such spots, if 
you could perhaps add it there.
I personally don't care much for the pep8 errors, IMHO the code reads better 
this way.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/486#issuecomment-281268640
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#486][comment] Migrate OTP import script to python-cryptography

2017-02-20 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/486
Title: #486: Migrate OTP import script to python-cryptography

tiran commented:
"""
Thanks Indiana Nathaniel, good code archaeology. The ticket aligns nicely with 
https://fedorahosted.org/freeipa/ticket/6650
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/486#issuecomment-281163303
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#486][comment] Migrate OTP import script to python-cryptography

2017-02-20 Thread npmccallum
  URL: https://github.com/freeipa/freeipa/pull/486
Title: #486: Migrate OTP import script to python-cryptography

npmccallum commented:
"""
This is an old patch I found on my system that doesn't appear to be merged.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/486#issuecomment-281159669
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code