[Freeipa-devel] [freeipa PR#50] Add cert checks in ipa-server-certinstall (comment)
jcholast commented on a pull request """ Functional ACK, but please don't use newlines in exception messages. If you want the original error on a separate line, you can use the logger to log it, but I think it would be preferable to use this format: ``` Peer's certificate issuer is not trusted ((SEC_ERROR_UNKNOWN_ISSUER) Peer's Certificate issuer is not recognized). Please run ipa-cacert-manage install and ipa-certupdate to install the CA certificate. ``` """ See the full comment at https://github.com/freeipa/freeipa/pull/50#issuecomment-247299454 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#50] Add cert checks in ipa-server-certinstall (comment)
flo-renaud commented on a pull request """ Bump for review """ See the full comment at https://github.com/freeipa/freeipa/pull/50#issuecomment-246921696 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#50] Add cert checks in ipa-server-certinstall (comment)
jcholast commented on a pull request """ More comments inline. """ See the full comment at https://github.com/freeipa/freeipa/pull/50#issuecomment-244967015 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#50] Add cert checks in ipa-server-certinstall (comment)
jcholast commented on a pull request """ NACK, see my inline comments above. """ See the full comment at https://github.com/freeipa/freeipa/pull/50#issuecomment-244858726 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
