URL: https://github.com/freeipa/freeipa/pull/525
Author: tiran
 Title: #525: Remove import nss from test_ldap
Action: opened

PR body:
"""
test_ldap just imported nss.nss to call nss_init_nodb(). It should be
safe to remove the call. Let's see what CI has to say.

Signed-off-by: Christian Heimes <chei...@redhat.com>
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/525/head:pr525
git checkout pr525
From 7392321feed2eeff85f925ece218a97bab7fe407 Mon Sep 17 00:00:00 2001
From: Christian Heimes <chei...@redhat.com>
Date: Wed, 1 Mar 2017 11:33:00 +0100
Subject: [PATCH] Remove import nss from test_ldap

test_ldap just imported nss.nss to call nss_init_nodb(). It should be
safe to remove the call. Let's see what CI has to say.

Signed-off-by: Christian Heimes <chei...@redhat.com>
---
 ipatests/test_ipaserver/test_ldap.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/ipatests/test_ipaserver/test_ldap.py b/ipatests/test_ipaserver/test_ldap.py
index 3a0b4b2..e7ba867 100644
--- a/ipatests/test_ipaserver/test_ldap.py
+++ b/ipatests/test_ipaserver/test_ldap.py
@@ -31,7 +31,6 @@
 import pytest
 import nose
 from nose.tools import assert_raises  # pylint: disable=E0611
-import nss.nss as nss
 import six
 
 from ipaplatform.paths import paths
@@ -53,7 +52,6 @@ class test_ldap(object):
     def setup(self):
         self.conn = None
         self.ldapuri = 'ldap://%s' % ipautil.format_netloc(api.env.host)
-        nss.nss_init_nodb()
         self.dn = DN(('krbprincipalname','ldap/%s@%s' % (api.env.host, api.env.realm)),
                      ('cn','services'),('cn','accounts'),api.env.basedn)
 
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to