URL: https://github.com/freeipa/freeipa/pull/566
Author: pvoborni
 Title: #566: webui: do not warn about CAs if there is only one master
Action: synchronized

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/566/head:pr566
git checkout pr566
From cee2b37c31643cf520665a495d0cb6965540bee8 Mon Sep 17 00:00:00 2001
From: Petr Vobornik <pvobo...@redhat.com>
Date: Thu, 9 Mar 2017 20:06:25 +0100
Subject: [PATCH] webui: do not warn about CAs if there is only one master

Web UI showed pop-up dialog which recommends to install additional CA in
topology section when only 1 CA existed even if there was only one master.

Though behind the pop-up is to prevent situation, where multiple replicas
are installed but neither with --setup-ca option and thus risking to loose
CA when original master is lost.

The warning was displayed also if only one IPA server exists. It is unnecessary
to annoy admin only about CA because the entire IPA is not duplicated.

Therefore the pop-up is now shown only one IPA server exists.

https://pagure.io/freeipa/issue/6598
---
 install/ui/src/freeipa/topology.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/install/ui/src/freeipa/topology.js b/install/ui/src/freeipa/topology.js
index c33adba..ae94f98 100644
--- a/install/ui/src/freeipa/topology.js
+++ b/install/ui/src/freeipa/topology.js
@@ -497,6 +497,10 @@ topology.servers_search_facet = function(spec, no_init) {
             on_success(data, text_status, xhr);
 
             var result = data.result.results;
+
+            // Do not show warning if there is only one master
+            if (result.length <= 1) return;
+
             var counter = 0;
 
             for (var i=0, l=result.length; i<l; i++) {
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to