URL: https://github.com/freeipa/freeipa/pull/593
Title: #593: Add make devcheck for developers
MartinBasti commented:
"""
master:
* e357133fd7b276ccabfe1896ee948f2bb3541d94 Add make devcheck for developers
* 6c092c24b2bfbba0a3f263d88f7a0dbf83f24869 Skip test_session_storage in
ipaclient
URL: https://github.com/freeipa/freeipa/pull/593
Title: #593: Add make devcheck for developers
MartinBasti commented:
"""
Ah right the description hasn't been updated
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/593#issuecomment-290678887
--
Manage your subscription
URL: https://github.com/freeipa/freeipa/pull/593
Title: #593: Add make devcheck for developers
MartinBasti commented:
"""
Needs rebase
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/593#issuecomment-290679169
--
Manage your subscription for the Freeipa-devel mailing
URL: https://github.com/freeipa/freeipa/pull/593
Title: #593: Add make devcheck for developers
MartinBasti commented:
"""
@stlaz why is this ACKed when it depends on #670 ?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/593#issuecomment-290678060
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/593
Title: #593: Add make devcheck for developers
stlaz commented:
"""
@MartinBasti #670 was ACKed already and the commit was originally a part of
this.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/593
Title: #593: Add make devcheck for developers
stlaz commented:
"""
Thanks, ACK.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/593#issuecomment-290673932
--
Manage your subscription for the Freeipa-devel mailing list:
URL: https://github.com/freeipa/freeipa/pull/593
Title: #593: Add make devcheck for developers
tiran commented:
"""
I split the changes to session storage tests into a separate commit. The other
commit is in #670
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/593
Title: #593: Add make devcheck for developers
stlaz commented:
"""
Whichever is ok with you, I don't mind if it's in the same PR if it is related
to the same ticket.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/593
Title: #593: Add make devcheck for developers
tiran commented:
"""
```test_session_storage``` is not a unit test or functional test. It is an
integration test that depends on a valid Kerberos configuration and session. Do
you prefer a separate
URL: https://github.com/freeipa/freeipa/pull/593
Title: #593: Add make devcheck for developers
stlaz commented:
"""
The changes to Makefile and configure.ac are just fine. I understand that
changes in the `ipapython/session_storage.py` are done elsewhere so once that
is pushed, we'll need a
10 matches
Mail list logo
