[Freeipa-devel] [freeipa PR#593][comment] Add make devcheck for developers
URL: https://github.com/freeipa/freeipa/pull/593 Title: #593: Add make devcheck for developers MartinBasti commented: """ master: * e357133fd7b276ccabfe1896ee948f2bb3541d94 Add make devcheck for developers * 6c092c24b2bfbba0a3f263d88f7a0dbf83f24869 Skip test_session_storage in ipaclient unittest mode ipa-4-5: * 89ab24f1fbb58feb603d60503c685ebad41a4237 Add make devcheck for developers * c80adf6e0d16f807f90479660af22540cd92d774 Skip test_session_storage in ipaclient unittest mode """ See the full comment at https://github.com/freeipa/freeipa/pull/593#issuecomment-290691783 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#593][comment] Add make devcheck for developers
URL: https://github.com/freeipa/freeipa/pull/593 Title: #593: Add make devcheck for developers MartinBasti commented: """ Ah right the description hasn't been updated """ See the full comment at https://github.com/freeipa/freeipa/pull/593#issuecomment-290678887 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#593][comment] Add make devcheck for developers
URL: https://github.com/freeipa/freeipa/pull/593 Title: #593: Add make devcheck for developers MartinBasti commented: """ Needs rebase """ See the full comment at https://github.com/freeipa/freeipa/pull/593#issuecomment-290679169 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#593][comment] Add make devcheck for developers
URL: https://github.com/freeipa/freeipa/pull/593 Title: #593: Add make devcheck for developers MartinBasti commented: """ @stlaz why is this ACKed when it depends on #670 ? """ See the full comment at https://github.com/freeipa/freeipa/pull/593#issuecomment-290678060 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#593][comment] Add make devcheck for developers
URL: https://github.com/freeipa/freeipa/pull/593 Title: #593: Add make devcheck for developers stlaz commented: """ @MartinBasti #670 was ACKed already and the commit was originally a part of this. """ See the full comment at https://github.com/freeipa/freeipa/pull/593#issuecomment-290678477 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#593][comment] Add make devcheck for developers
URL: https://github.com/freeipa/freeipa/pull/593 Title: #593: Add make devcheck for developers stlaz commented: """ Thanks, ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/593#issuecomment-290673932 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#593][comment] Add make devcheck for developers
URL: https://github.com/freeipa/freeipa/pull/593 Title: #593: Add make devcheck for developers tiran commented: """ I split the changes to session storage tests into a separate commit. The other commit is in #670 """ See the full comment at https://github.com/freeipa/freeipa/pull/593#issuecomment-29066 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#593][comment] Add make devcheck for developers
URL: https://github.com/freeipa/freeipa/pull/593 Title: #593: Add make devcheck for developers stlaz commented: """ Whichever is ok with you, I don't mind if it's in the same PR if it is related to the same ticket. """ See the full comment at https://github.com/freeipa/freeipa/pull/593#issuecomment-290655653 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#593][comment] Add make devcheck for developers
URL: https://github.com/freeipa/freeipa/pull/593 Title: #593: Add make devcheck for developers tiran commented: """ ```test_session_storage``` is not a unit test or functional test. It is an integration test that depends on a valid Kerberos configuration and session. Do you prefer a separate PR? """ See the full comment at https://github.com/freeipa/freeipa/pull/593#issuecomment-290654739 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#593][comment] Add make devcheck for developers
URL: https://github.com/freeipa/freeipa/pull/593 Title: #593: Add make devcheck for developers stlaz commented: """ The changes to Makefile and configure.ac are just fine. I understand that changes in the `ipapython/session_storage.py` are done elsewhere so once that is pushed, we'll need a rebase. I don't see the explanation why we're disabling the test in `ipatests/test_ipapython/test_session_storage.py `, that might need a different commit? """ See the full comment at https://github.com/freeipa/freeipa/pull/593#issuecomment-290651108 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
