URL: https://github.com/freeipa/freeipa/pull/620
Title: #620: [WIP] Fixing 6549
felipevolpone commented:
"""
@HonzaCholasta @tomaskrizek please, check if it looks good to you. thank you
for helping me guys :+1:
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/620
Title: #620: [WIP] Fixing 6549
HonzaCholasta commented:
"""
@felipevolpone, the comment should explain *why* DM authentication has to be
used.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/620#issuecomment-287990430
--
URL: https://github.com/freeipa/freeipa/pull/620
Title: #620: [WIP] Fixing 6549
tomaskrizek commented:
"""
Seems all right, but I'd go with a more informative summary to make it a bit
more clear what's changed when looking through the log:
```
replica install: fix ldap connection in domlvl 0
URL: https://github.com/freeipa/freeipa/pull/620
Title: #620: [WIP] Fixing 6549
felipevolpone commented:
"""
What do you think about:
```
Fixing the replica install against IPA 3.0.0 master.
Now, at the domain level 0, the replica install always uses
Directory Manager credentials to create
URL: https://github.com/freeipa/freeipa/pull/620
Title: #620: [WIP] Fixing 6549
tomaskrizek commented:
"""
Please try to keep the commit message summary short and append the link to the
ticket at the end.
For example:
```
server install: require IPv6 stack to be enabled
Add checks to
URL: https://github.com/freeipa/freeipa/pull/620
Title: #620: [WIP] Fixing 6549
felipevolpone commented:
"""
@HonzaCholasta, @MartinBasti done :)
Please, check if the commit message and the code comment are good enough.
Thank you
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/620
Title: #620: [WIP] Fixing 6549
MartinBasti commented:
"""
Please merge commits into one and please use full description in commit message
instead of ticket number.
"""
See the full comment at
