[Freeipa-devel] [freeipa PR#621][comment] Add --force-password-reset to user_mod in user.py

2017-03-21 Thread HonzaCholasta
  URL: https://github.com/freeipa/freeipa/pull/621
Title: #621: Add --force-password-reset to user_mod in user.py

HonzaCholasta commented:
"""
@redhatrises, do not handle the format yourself, use the `DateTime` param type. 
Note that you will need to extend it to correctly interpret the "now" value.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/621#issuecomment-288101283
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#621][comment] Add --force-password-reset to user_mod in user.py

2017-03-21 Thread redhatrises
  URL: https://github.com/freeipa/freeipa/pull/621
Title: #621: Add --force-password-reset to user_mod in user.py

redhatrises commented:
"""
@HonzaCholasta that's an interesting idea. Most of the time, a password reset 
is forced immediately, but that does provide more flexibility. I assume that 
the datetime input should match the `2017-03-21T07:58:05Z` format?
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/621#issuecomment-288063972
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#621][comment] Add --force-password-reset to user_mod in user.py

2017-03-21 Thread HonzaCholasta
  URL: https://github.com/freeipa/freeipa/pull/621
Title: #621: Add --force-password-reset to user_mod in user.py

HonzaCholasta commented:
"""
I have given this some thought over the night - maybe we should make the option 
more generic and allow the user to specify the expiration time rather than 
special case it for "now" time, i.e. 
`--password-expiration=2017-03-21T07:58:05Z` to expire the password at a 
specific time, `--password-expiration=now` to expire the password now, just 
like `--force-password-reset` does.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/621#issuecomment-287992866
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#621][comment] Add --force-password-reset to user_mod in user.py

2017-03-20 Thread abbra
  URL: https://github.com/freeipa/freeipa/pull/621
Title: #621: Add --force-password-reset to user_mod in user.py

abbra commented:
"""
Ok, let's go with `user-mod` as original request goes, based on the fact that 
we are not changing the password, we are changing its properties.

LGTM.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/621#issuecomment-287819233
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#621][comment] Add --force-password-reset to user_mod in user.py

2017-03-20 Thread redhatrises
  URL: https://github.com/freeipa/freeipa/pull/621
Title: #621: Add --force-password-reset to user_mod in user.py

redhatrises commented:
"""
Okay, so since it will reside in one location, should it be `user-mod` (PR 
already uses `user-mod`) or `passwd`?
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/621#issuecomment-287807607
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#621][comment] Add --force-password-reset to user_mod in user.py

2017-03-20 Thread HonzaCholasta
  URL: https://github.com/freeipa/freeipa/pull/621
Title: #621: Add --force-password-reset to user_mod in user.py

HonzaCholasta commented:
"""
Actually, maybe `user-mod` is a better place for the option, as it does LDAP 
modify operation, whereas `passwd` does LDAP password change extended operation.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/621#issuecomment-287781294
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#621][comment] Add --force-password-reset to user_mod in user.py

2017-03-20 Thread HonzaCholasta
  URL: https://github.com/freeipa/freeipa/pull/621
Title: #621: Add --force-password-reset to user_mod in user.py

HonzaCholasta commented:
"""
I don't agree. There should be one and only one obvious way to do it. There is 
no real benefit in having this in multiple different places, it just adds 
unnecessary complexity. Let's not repeat mistakes of the past and put this 
solely into `passwd`.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/621#issuecomment-287776107
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#621][comment] Add --force-password-reset to user_mod in user.py

2017-03-20 Thread HonzaCholasta
  URL: https://github.com/freeipa/freeipa/pull/621
Title: #621: Add --force-password-reset to user_mod in user.py

HonzaCholasta commented:
"""
I don't agree. There should be one and only one obvious way to do it. There is 
no real benefit in having this in multiple different places, it just adds 
unnecessary complexity. Let's not repeat mistakes of the past and put this 
solely into `passwd`.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/621#issuecomment-287776107
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#621][comment] Add --force-password-reset to user_mod in user.py

2017-03-20 Thread abbra
  URL: https://github.com/freeipa/freeipa/pull/621
Title: #621: Add --force-password-reset to user_mod in user.py

abbra commented:
"""
Hm. `ipa user-mod` has --random and also supports specifying --password, so 
yes, both interfaces should be provided.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/621#issuecomment-287772855
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#621][comment] Add --force-password-reset to user_mod in user.py

2017-03-20 Thread redhatrises
  URL: https://github.com/freeipa/freeipa/pull/621
Title: #621: Add --force-password-reset to user_mod in user.py

redhatrises commented:
"""
@abbra why not have it in both `ipa user-mod` and `ipa passwd`?
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/621#issuecomment-287761849
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#621][comment] Add --force-password-reset to user_mod in user.py

2017-03-18 Thread abbra
  URL: https://github.com/freeipa/freeipa/pull/621
Title: #621: Add --force-password-reset to user_mod in user.py

abbra commented:
"""
I would prefer this to be an option in `ipa passwd`, e.g. `ipa passwd 
--force-reset` which instead of modifying a user password would modify 
krbPasswordExpiration value.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/621#issuecomment-287559962
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code