URL: https://github.com/freeipa/freeipa/pull/639
Title: #639: WebUI: Login for AD Users
martbab commented:
"""
master:
* 1dcdcd12f4336c98e7507fe0e7f0c0da2bc69eba WebUI: check principals in lowercase
* 2992e3c5d480567cfdc71b38365d5d74f009b4d2 WebUI: add method for disabling item
in user
URL: https://github.com/freeipa/freeipa/pull/639
Title: #639: WebUI: Login for AD Users
pvoborni commented:
"""
The code changes looks good to me. ACK given that it works fine (@abbra 's
comment).
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/639#issuecomment-288961590
URL: https://github.com/freeipa/freeipa/pull/639
Title: #639: WebUI: Login for AD Users
abbra commented:
"""
LGTM and works just fine:
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/639#issuecomment-288956595
--
URL: https://github.com/freeipa/freeipa/pull/639
Title: #639: WebUI: Login for AD Users
pvomacka commented:
"""
I implemented all comments which you proposed and I also changed menu of AD
user selfservice - I removed User tab and renamed User ID override to Profile.
"""
See the full comment
