[Freeipa-devel] [freeipa PR#655][comment] httpinstance.disable_system_trust: Don't fail if module 'Root Certs' …

2017-03-28 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/655 Title: #655: httpinstance.disable_system_trust: Don't fail if module 'Root Certs' … tomaskrizek commented: """ ipa-4-5: * 2a499551ca5ddf2596cc19a77f47c34e9f5c10c5 httpinstance.disable_system_trust: Don't fail if module 'Root Certs' is not

[Freeipa-devel] [freeipa PR#655][comment] httpinstance.disable_system_trust: Don't fail if module 'Root Certs' …

2017-03-28 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/655 Title: #655: httpinstance.disable_system_trust: Don't fail if module 'Root Certs' … stlaz commented: """ This fixes the mentioned issue. I did not test whether the actual disable works but I should hope so as I don't see how this could break

[Freeipa-devel] [freeipa PR#655][comment] httpinstance.disable_system_trust: Don't fail if module 'Root Certs' …

2017-03-27 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/655 Title: #655: httpinstance.disable_system_trust: Don't fail if module 'Root Certs' … stlaz commented: """ @HonzaCholasta You're right, I completely forgot about that one. """ See the full comment at

[Freeipa-devel] [freeipa PR#655][comment] httpinstance.disable_system_trust: Don't fail if module 'Root Certs' …

2017-03-27 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/655 Title: #655: httpinstance.disable_system_trust: Don't fail if module 'Root Certs' … HonzaCholasta commented: """ @stlaz, you can't do just `-disable`, as that would break upgrade (note that the `-list` is there because `-disable` always reports

[Freeipa-devel] [freeipa PR#655][comment] httpinstance.disable_system_trust: Don't fail if module 'Root Certs' …

2017-03-27 Thread dkupka
URL: https://github.com/freeipa/freeipa/pull/655 Title: #655: httpinstance.disable_system_trust: Don't fail if module 'Root Certs' … dkupka commented: """ @tiran @stlaz Makes sense. I will update it accordingly. Thanks for suggestions. """ See the full comment at

[Freeipa-devel] [freeipa PR#655][comment] httpinstance.disable_system_trust: Don't fail if module 'Root Certs' …

2017-03-27 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/655 Title: #655: httpinstance.disable_system_trust: Don't fail if module 'Root Certs' … stlaz commented: """ @tiran I of course agree on narrowing the broad except down, my point is we should rather remove the whole `-list` part and just try to do

[Freeipa-devel] [freeipa PR#655][comment] httpinstance.disable_system_trust: Don't fail if module 'Root Certs' …

2017-03-27 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/655 Title: #655: httpinstance.disable_system_trust: Don't fail if module 'Root Certs' … stlaz commented: """ @tiran I of course agree on narrowing the broad except down, my point is we should rather remove the whole `-list` part and just try to do

[Freeipa-devel] [freeipa PR#655][comment] httpinstance.disable_system_trust: Don't fail if module 'Root Certs' …

2017-03-27 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/655 Title: #655: httpinstance.disable_system_trust: Don't fail if module 'Root Certs' … tiran commented: """ @stlaz The broad except also catches and ignores typos in the command line or missing ```modutil``` binary. """ See the full comment at

[Freeipa-devel] [freeipa PR#655][comment] httpinstance.disable_system_trust: Don't fail if module 'Root Certs' …

2017-03-27 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/655 Title: #655: httpinstance.disable_system_trust: Don't fail if module 'Root Certs' … stlaz commented: """ For the record: ```bash [slaznick@vm-066 ~]$ sudo modutil -dbdir nssdb/ -disable 'Root Certs' -force ERROR: Module "Root Certs" not found in

[Freeipa-devel] [freeipa PR#655][comment] httpinstance.disable_system_trust: Don't fail if module 'Root Certs' …

2017-03-27 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/655 Title: #655: httpinstance.disable_system_trust: Don't fail if module 'Root Certs' … stlaz commented: """ For the record: ```bash [slaznick@vm-066 ~]$ sudo modutil -dbdir nssdb/ -disable 'Root Certs' -force ERROR: Module "Root Certs" not found in

[Freeipa-devel] [freeipa PR#655][comment] httpinstance.disable_system_trust: Don't fail if module 'Root Certs' …

2017-03-27 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/655 Title: #655: httpinstance.disable_system_trust: Don't fail if module 'Root Certs' … stlaz commented: """ Hm, I believe the `-list` operation was there just to check whether the module is there. If `modutil` fails like this no matter the

[Freeipa-devel] [freeipa PR#655][comment] httpinstance.disable_system_trust: Don't fail if module 'Root Certs' …

2017-03-27 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/655 Title: #655: httpinstance.disable_system_trust: Don't fail if module 'Root Certs' … stlaz commented: """ Hm, I believe the `-list` operation was there just to check whether the module is there. If `modutil` fails like this no matter the