[Freeipa-devel] [freeipa PR#669][comment] server: make sure we test for sss_nss_getlistbycert

2017-03-29 Thread tomaskrizek
  URL: https://github.com/freeipa/freeipa/pull/669
Title: #669: server: make sure we test for sss_nss_getlistbycert

tomaskrizek commented:
"""
master:

* 67e5244cad72bef76de1c4df47a0c77a672fa861 server: make sure we test for 
sss_nss_getlistbycert
ipa-4-5:

* 8be6987da72dff0ebd4e02c946b45b5b1705d880 server: make sure we test for 
sss_nss_getlistbycert
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/669#issuecomment-290022005
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#669][comment] server: make sure we test for sss_nss_getlistbycert

2017-03-29 Thread tomaskrizek
  URL: https://github.com/freeipa/freeipa/pull/669
Title: #669: server: make sure we test for sss_nss_getlistbycert

tomaskrizek commented:
"""
Works as expected.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/669#issuecomment-290019629
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#669][comment] server: make sure we test for sss_nss_getlistbycert

2017-03-29 Thread abbra
  URL: https://github.com/freeipa/freeipa/pull/669
Title: #669: server: make sure we test for sss_nss_getlistbycert

abbra commented:
"""
On the systems where pkg-config is available, positive result from pkg-config 
check means headers are available because pkg-config files are part of 
development sub-packages. Symbol check in a library is enough then.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/669#issuecomment-290016098
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#669][comment] server: make sure we test for sss_nss_getlistbycert

2017-03-29 Thread tiran
  URL: https://github.com/freeipa/freeipa/pull/669
Title: #669: server: make sure we test for sss_nss_getlistbycert

tiran commented:
"""
AC_CHECK_LIB only checks for functions in libs. Compilation may still fail if 
header files and library are not in sync. IMHO we don't have to care about this 
broken case.

LGTM
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/669#issuecomment-290011518
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code