martbab commented on a pull request
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/003b364c5a06a5adc89bac7371f46d534cfb4616
ipa-4-4:
https://fedorahosted.org/freeipa/changeset/85b98059f91670bd489c35816b2ff901a7820c4f
"""
See the full comment at
https://github.com/freeipa/f
stlaz commented on a pull request
"""
Please add ```assert isinstance(dn, DN)``` as in the parent method.
Also, I think maybe it's safer to check for rdns emptiness before you try to
assign from it.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/68#issuecomment-245878203
-
stlaz commented on a pull request
"""
LGTM, just please add ```assert isinstance(dn, DN)``` as in the parent method.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/68#issuecomment-245878203
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.c
