URL: https://github.com/freeipa/freeipa/pull/699
Title: #699: ipaclient/ipapython macOS compatibility fixes
pvoborni commented:
"""
IMO this can be put to 4.5.1 (ipa-4-5 branch) but in order to do it, according
to FreeIPA devel processes, it needs to be attached (have a ticket link in
commit
URL: https://github.com/freeipa/freeipa/pull/699
Title: #699: ipaclient/ipapython macOS compatibility fixes
abbra commented:
"""
Well, given that it is not officially supported yet, go ahead.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/699#issuecomment-295195255
--
URL: https://github.com/freeipa/freeipa/pull/699
Title: #699: ipaclient/ipapython macOS compatibility fixes
tiran commented:
"""
@abbra is there any reason to delay the merge? I like to get the fixes into 4.5
for the upcoming 4.5.1 release. This commit may not be sufficient for full
macOS
URL: https://github.com/freeipa/freeipa/pull/699
Title: #699: ipaclient/ipapython macOS compatibility fixes
abbra commented:
"""
Ok, so far I cannot build a wheel from git repo on Mac OS X as we have a number
of limitations ourselves -- we need to fix our configure to allow just
generating
URL: https://github.com/freeipa/freeipa/pull/699
Title: #699: ipaclient/ipapython macOS compatibility fixes
abbra commented:
"""
I still need to test the whole set on Mac OS X myself as we have no way to test
that in CI. Thus, this PR will depend on me (or some one else from FreeIPA
team) to
URL: https://github.com/freeipa/freeipa/pull/699
Title: #699: ipaclient/ipapython macOS compatibility fixes
tiran commented:
"""
No, we don't need to sync the directory. These are cache files. It's only
important that we don't have half-written cache files on disk. A missing cache
file is
URL: https://github.com/freeipa/freeipa/pull/699
Title: #699: ipaclient/ipapython macOS compatibility fixes
tiran commented:
"""
I wrote that ```fdatasync``` -> ```fsync``` is fine. It's my code after all.
Explanation: fdatasync is a slightly optimized version of fsync that does not
flush
URL: https://github.com/freeipa/freeipa/pull/699
Title: #699: ipaclient/ipapython macOS compatibility fixes
abbra commented:
"""
Note that we need something similar to
https://github.com/untitaker/python-atomicwrites/commit/2bdd9dae62b7434c7b2383ce45fb515bdf70c3c3
to behave properly on Mac OS
URL: https://github.com/freeipa/freeipa/pull/699
Title: #699: ipaclient/ipapython macOS compatibility fixes
abbra commented:
"""
Please don't set ACK yet, I'm not finished with review.
I do not want to replace fdatasync() with fsync(), this is not correct towards
other platforms.
I haven't
