URL: https://github.com/freeipa/freeipa/pull/716
Title: #716: Fix minor typos
stlaz commented:
"""
I asked today at a meeting and the `ipaclient/remote_plugins/2_*/*.py` changes
are fine. If you could possibly change the one small issue, we will finally be
able tu push this :)
"""
See the
URL: https://github.com/freeipa/freeipa/pull/716
Title: #716: Fix minor typos
stlaz commented:
"""
Except for the one change I pointed out, this is all OK with me. The only thing
I am not sure is whether we can go changing the doc texts in
`ipaclient/remote_plugins/2_*/*.py` since these are
URL: https://github.com/freeipa/freeipa/pull/716
Title: #716: Fix minor typos
realsobek commented:
"""
For some commits the titles were the same, but the contents were different.
That was due to my working habit.
The messy `git log` output was due to my attempts to fix the problems.
`git
URL: https://github.com/freeipa/freeipa/pull/716
Title: #716: Fix minor typos
stlaz commented:
"""
Please, see what `git rebase -i master` will do for you, along with `git commit
--amend --author="Author Name "`.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/716
Title: #716: Fix minor typos
stlaz commented:
"""
Please, see what `git rebase -i master` will do for you, along with `git commit
--amend --author="Author Name "`.
**edit:** I see a lot of confusion in your commits in this
URL: https://github.com/freeipa/freeipa/pull/716
Title: #716: Fix minor typos
stlaz commented:
"""
Please, see what `git rebase -i master` will do for you.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/716#issuecomment-296531382
--
Manage your subscription for the
URL: https://github.com/freeipa/freeipa/pull/716
Title: #716: Fix minor typos
stlaz commented:
"""
Please, see what `git rebase -i master` will do for you.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/716#issuecomment-296531382
--
Manage your subscription for the
URL: https://github.com/freeipa/freeipa/pull/716
Title: #716: Fix minor typos
realsobek commented:
"""
I cannot get rid of commit cb4250a to normalize `From:`. Hence I am going to
close this PR soon. Afterwards I will create a new branch in my fork, copy all
changes (excluding changes to PO
URL: https://github.com/freeipa/freeipa/pull/716
Title: #716: Fix minor typos
realsobek commented:
"""
> There are no tickets associated with these changes.
On the other hand, if the ticket is required for giving attribution, I will
create it.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/716
Title: #716: Fix minor typos
realsobek commented:
"""
> There are no tickets associated with these changes.
On the other hand, if the ticket is required for giving attribution, I will
create it.
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/716
Title: #716: Fix minor typos
realsobek commented:
"""
Thank you for guiding me. :)
> There are no tickets associated with these changes.
In the sense of:
http://www.freeipa.org/page/Contribute/Code#Update_Trac_ticket
I consider my code changes
URL: https://github.com/freeipa/freeipa/pull/716
Title: #716: Fix minor typos
abbra commented:
"""
Thanks for this pull request.
There are no tickets associated with these changes.
The changes themselves are controversial. Do not change `--forwarder-*` to
`--forward-*` because you are
URL: https://github.com/freeipa/freeipa/pull/716
Title: #716: Fix minor typos
realsobek commented:
"""
There are 353 occurrences of 'plugable'. 2 in file names. 351 in code.
I can make the change in a separate branch. But I cannot evaluate the outcome.
Hence I would like to have your opinion
13 matches
Mail list logo