[Freeipa-devel] Re: [PATCH] Fix typos and minor bugs in baseldap. Add --all to LDAPUpdate.

2009-09-11 Thread Rob Crittenden

Pavel Zuna wrote:

Rob Crittenden wrote:

Pavel Zůna wrote:
Fixes some minor things in baseldap. It also add the --all options 
(to display all attribute) to LDAPUpdate.


Pavel


Why are you not returning failed anymore with post_callback?
Because that was a mistake, I meant to return dn, but wrote failed for 
some reason. We only need to return immutable types in callbacks, 
because everything else can be changed "in place".



rob



Pavel


Ok, ack and pushed to master.

I wonder if --all and --raw should be global options instead so they 
don't show show up in help. It is a little odd to see "print entries as 
they are stored in LDAP" in add help.


rob



smime.p7s
Description: S/MIME Cryptographic Signature
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] Re: [PATCH] Fix typos and minor bugs in baseldap. Add --all to LDAPUpdate.

2009-09-10 Thread Pavel Zuna

Rob Crittenden wrote:

Pavel Zůna wrote:
Fixes some minor things in baseldap. It also add the --all options (to 
display all attribute) to LDAPUpdate.


Pavel


Why are you not returning failed anymore with post_callback?
Because that was a mistake, I meant to return dn, but wrote failed for some 
reason. We only need to return immutable types in callbacks, because everything 
else can be changed "in place".



rob



Pavel

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


[Freeipa-devel] Re: [PATCH] Fix typos and minor bugs in baseldap. Add --all to LDAPUpdate.

2009-09-10 Thread Rob Crittenden

Pavel Zůna wrote:
Fixes some minor things in baseldap. It also add the --all options (to 
display all attribute) to LDAPUpdate.


Pavel


Why are you not returning failed anymore with post_callback?

rob



smime.p7s
Description: S/MIME Cryptographic Signature
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel