Re: [Freeipa-devel] pylint: remove unused variables

2016-09-23 Thread Standa Laznicka
On 09/23/2016 02:11 PM, Martin Basti wrote: On 23.09.2016 14:12, Jan Cholasta wrote: On 23.9.2016 13:23, Standa Laznicka wrote: On 09/23/2016 07:28 AM, Jan Cholasta wrote: On 22.9.2016 16:39, Martin Basti wrote: Hello all, In 4.5, I would like to remove all unused variables from code and

Re: [Freeipa-devel] pylint: remove unused variables

2016-09-23 Thread Martin Basti
On 23.09.2016 14:12, Jan Cholasta wrote: On 23.9.2016 13:23, Standa Laznicka wrote: On 09/23/2016 07:28 AM, Jan Cholasta wrote: On 22.9.2016 16:39, Martin Basti wrote: Hello all, In 4.5, I would like to remove all unused variables from code and enable pylint check. Due to big amount of un

Re: [Freeipa-devel] pylint: remove unused variables

2016-09-23 Thread Jan Cholasta
On 23.9.2016 13:23, Standa Laznicka wrote: On 09/23/2016 07:28 AM, Jan Cholasta wrote: On 22.9.2016 16:39, Martin Basti wrote: Hello all, In 4.5, I would like to remove all unused variables from code and enable pylint check. Due to big amount of unused variables in the code this will be longte

Re: [Freeipa-devel] pylint: remove unused variables

2016-09-23 Thread Standa Laznicka
On 09/23/2016 07:28 AM, Jan Cholasta wrote: On 22.9.2016 16:39, Martin Basti wrote: Hello all, In 4.5, I would like to remove all unused variables from code and enable pylint check. Due to big amount of unused variables in the code this will be longterm effort. Why this?: * better code readab

Re: [Freeipa-devel] pylint: remove unused variables

2016-09-23 Thread Jan Cholasta
On 23.9.2016 10:40, Petr Spacek wrote: On 23.9.2016 07:28, Jan Cholasta wrote: On 22.9.2016 16:39, Martin Basti wrote: Hello all, In 4.5, I would like to remove all unused variables from code and enable pylint check. Due to big amount of unused variables in the code this will be longterm effor

Re: [Freeipa-devel] pylint: remove unused variables

2016-09-23 Thread Petr Spacek
On 23.9.2016 07:28, Jan Cholasta wrote: > On 22.9.2016 16:39, Martin Basti wrote: >> Hello all, >> >> In 4.5, I would like to remove all unused variables from code and enable >> pylint check. Due to big amount of unused variables in the code this >> will be longterm effort. >> >> Why this?: >> >> *

Re: [Freeipa-devel] pylint: remove unused variables

2016-09-22 Thread Jan Cholasta
On 22.9.2016 16:39, Martin Basti wrote: Hello all, In 4.5, I would like to remove all unused variables from code and enable pylint check. Due to big amount of unused variables in the code this will be longterm effort. Why this?: * better code readability * removing dead code * unused variabl

Re: [Freeipa-devel] pylint: remove unused variables

2016-09-22 Thread Martin Basti
On 22.09.2016 18:05, Tomas Krizek wrote: On 09/22/2016 06:00 PM, Martin Basti wrote: On 22.09.2016 17:59, Tomas Krizek wrote: On 09/22/2016 04:39 PM, Martin Basti wrote: Hello all, In 4.5, I would like to remove all unused variables from code and enable pylint check. Due to big amount of

Re: [Freeipa-devel] pylint: remove unused variables

2016-09-22 Thread Tomas Krizek
On 09/22/2016 06:00 PM, Martin Basti wrote: On 22.09.2016 17:59, Tomas Krizek wrote: On 09/22/2016 04:39 PM, Martin Basti wrote: Hello all, In 4.5, I would like to remove all unused variables from code and enable pylint check. Due to big amount of unused variables in the code this will be

Re: [Freeipa-devel] pylint: remove unused variables

2016-09-22 Thread Martin Basti
On 22.09.2016 17:59, Tomas Krizek wrote: On 09/22/2016 04:39 PM, Martin Basti wrote: Hello all, In 4.5, I would like to remove all unused variables from code and enable pylint check. Due to big amount of unused variables in the code this will be longterm effort. Why this?: * better code

Re: [Freeipa-devel] pylint: remove unused variables

2016-09-22 Thread Tomas Krizek
On 09/22/2016 04:39 PM, Martin Basti wrote: Hello all, In 4.5, I would like to remove all unused variables from code and enable pylint check. Due to big amount of unused variables in the code this will be longterm effort. Why this?: * better code readability * removing dead code * unused

[Freeipa-devel] pylint: remove unused variables

2016-09-22 Thread Martin Basti
Hello all, In 4.5, I would like to remove all unused variables from code and enable pylint check. Due to big amount of unused variables in the code this will be longterm effort. Why this?: * better code readability * removing dead code * unused variable may uncover potential bug It is cl