Re: [Freeipa-devel] [PATCH] 0001 Fix ipa-client-install --uninstall crash

2014-07-08 Thread David Kupka
On 07/07/2014 09:15 PM, Petr Viktorin wrote: On 07/04/2014 08:47 AM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4273 David Kupka Hi, This works fine. Just two nitpicks in the log message: - %s means convert to string, so the str() is redundant - the logger methods take items

Re: [Freeipa-devel] [PATCH] 0001 Fix ipa-client-install --uninstall crash

2014-07-08 Thread Petr Viktorin
On 07/08/2014 07:59 AM, David Kupka wrote: On 07/07/2014 09:15 PM, Petr Viktorin wrote: On 07/04/2014 08:47 AM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4273 David Kupka Hi, This works fine. Just two nitpicks in the log message: - %s means convert to string, so the str()