Re: [Freeipa-devel] [PATCH] 0010 change uuid plugin to use libuuid
On Mon, 15 Nov 2010 14:45:18 +0100 Jakub Hrozek wrote: > On Mon, Nov 15, 2010 at 08:24:59AM -0500, Simo Sorce wrote: > > On Mon, 15 Nov 2010 13:48:51 +0100 > > Jakub Hrozek wrote: > > > > > On Thu, Nov 11, 2010 at 10:21:15AM -0500, Simo Sorce wrote: > > > > > > > > Directory Server guys decided not to expose internal uuid > > > > functions so change the ipa uuid plugin to use libuuid. > > > > > > > > > > The code looks OK and seems to work fine. > > > > > > > This changes the string format of the UUID records once again > > > > unfortunately ... > > > > > > > > > > I was about to ACK the patch, but I'm wondering, should I check > > > some other parts of the server to see whether the new format does > > > not break anything? I tested just with adding a user and checking > > > the ipauniqueid: attribute looks good. > > > > No I don't think anything more is required, except the attached > > patch I forgot to send, which reverts the format being tested in > > the xmlrpc unit tests. > > > > If you can ack both together it would be nice. > > > > Simo. > > > > Ack to both. Pushed to master. Simo. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0010 change uuid plugin to use libuuid
On Mon, Nov 15, 2010 at 08:24:59AM -0500, Simo Sorce wrote: > On Mon, 15 Nov 2010 13:48:51 +0100 > Jakub Hrozek wrote: > > > On Thu, Nov 11, 2010 at 10:21:15AM -0500, Simo Sorce wrote: > > > > > > Directory Server guys decided not to expose internal uuid functions > > > so change the ipa uuid plugin to use libuuid. > > > > > > > The code looks OK and seems to work fine. > > > > > This changes the string format of the UUID records once again > > > unfortunately ... > > > > > > > I was about to ACK the patch, but I'm wondering, should I check some > > other parts of the server to see whether the new format does not break > > anything? I tested just with adding a user and checking the > > ipauniqueid: attribute looks good. > > No I don't think anything more is required, except the attached patch I > forgot to send, which reverts the format being tested in the xmlrpc > unit tests. > > If you can ack both together it would be nice. > > Simo. > Ack to both. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0010 change uuid plugin to use libuuid
On Mon, 15 Nov 2010 13:48:51 +0100
Jakub Hrozek wrote:
> On Thu, Nov 11, 2010 at 10:21:15AM -0500, Simo Sorce wrote:
> >
> > Directory Server guys decided not to expose internal uuid functions
> > so change the ipa uuid plugin to use libuuid.
> >
>
> The code looks OK and seems to work fine.
>
> > This changes the string format of the UUID records once again
> > unfortunately ...
> >
>
> I was about to ACK the patch, but I'm wondering, should I check some
> other parts of the server to see whether the new format does not break
> anything? I tested just with adding a user and checking the
> ipauniqueid: attribute looks good.
No I don't think anything more is required, except the attached patch I
forgot to send, which reverts the format being tested in the xmlrpc
unit tests.
If you can ack both together it would be nice.
Simo.
--
Simo Sorce * Red Hat, Inc * New York
>From c3f38a53748bcbc2f0549193102afdb4ef2ad634 Mon Sep 17 00:00:00 2001
From: Simo Sorce
Date: Thu, 11 Nov 2010 10:20:35 -0500
Subject: [PATCH] Revert tests code to use the old uuid format.
---
tests/test_xmlrpc/xmlrpc_test.py |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/test_xmlrpc/xmlrpc_test.py b/tests/test_xmlrpc/xmlrpc_test.py
index a8074dace95410b90959e10c00b98a9aed544cc3..3a437d957229c2f9b070eb2be600eb846383cf3f 100644
--- a/tests/test_xmlrpc/xmlrpc_test.py
+++ b/tests/test_xmlrpc/xmlrpc_test.py
@@ -36,12 +36,12 @@ fuzzy_digits = Fuzzy('^\d+$', type=basestring)
# Matches an ipauniqueid like u'784d85fd-eae7-11de-9d01-54520012478b'
fuzzy_uuid = Fuzzy(
-'^[0-9a-f]{8}-[0-9a-f]{8}-[0-9a-f]{8}-[0-9a-f]{8}$'
+'^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$'
)
# Matches netgroup dn
fuzzy_netgroupdn = Fuzzy(
-'ipauniqueid=[0-9a-f]{8}-[0-9a-f]{8}-[0-9a-f]{8}-[0-9a-f]{8},cn=ng,cn=alt,%s' % api.env.basedn
+'ipauniqueid=[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12},cn=ng,cn=alt,%s' % api.env.basedn
)
try:
--
1.7.3.2
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0010 change uuid plugin to use libuuid
On Thu, Nov 11, 2010 at 10:21:15AM -0500, Simo Sorce wrote: > > Directory Server guys decided not to expose internal uuid functions so > change the ipa uuid plugin to use libuuid. > The code looks OK and seems to work fine. > This changes the string format of the UUID records once again > unfortunately ... > I was about to ACK the patch, but I'm wondering, should I check some other parts of the server to see whether the new format does not break anything? I tested just with adding a user and checking the ipauniqueid: attribute looks good. Jakub ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
