Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-10-13 Thread Rob Crittenden
Alexander Bokovoy wrote: On Wed, 12 Oct 2011, Rob Crittenden wrote: Well, in the "generate new file" option I think the output is a bit misleading. +print "New SSSD config will be generated. The old one is backed up and can be restored during uninstall" There could have been no existin

Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-10-13 Thread Alexander Bokovoy
On Wed, 12 Oct 2011, Rob Crittenden wrote: > Well, in the "generate new file" option I think the output is a bit > misleading. > > +print "New SSSD config will be generated. The old one is > backed up and can be restored during uninstall" > > There could have been no existing sssd.conf, r

Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-10-12 Thread Alexander Bokovoy
On Wed, 12 Oct 2011, Rob Crittenden wrote: > >>2) Be restrictive on ParseError and throw an error telling them to fix > >>their config file. Pros: we don't break an existing setup. Cons: FreeIPA > >>installation has been broken. > >> > >>3) Default to one of the above but provide a command-line fla

Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-10-12 Thread Rob Crittenden
Alexander Bokovoy wrote: On Tue, 13 Sep 2011, Stephen Gallagher wrote: On Tue, 2011-09-13 at 16:33 +0300, Alexander Bokovoy wrote: On Tue, 13 Sep 2011, Stephen Gallagher wrote: File "/usr/lib/python2.7/site-packages/SSSDConfig.py", line 1207, in import_config fd = open(configfile, 'r

Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-10-12 Thread Alexander Bokovoy
On Tue, 13 Sep 2011, Stephen Gallagher wrote: > On Tue, 2011-09-13 at 16:33 +0300, Alexander Bokovoy wrote: > > On Tue, 13 Sep 2011, Stephen Gallagher wrote: > > > > > File "/usr/lib/python2.7/site-packages/SSSDConfig.py", line 1207, > > > > > in import_config > > > > > fd = open(configfile

Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-09-13 Thread Stephen Gallagher
On Tue, 2011-09-13 at 16:33 +0300, Alexander Bokovoy wrote: > On Tue, 13 Sep 2011, Stephen Gallagher wrote: > > > > File "/usr/lib/python2.7/site-packages/SSSDConfig.py", line 1207, in > > > > import_config > > > > fd = open(configfile, 'r') > > > > IOError: [Errno 2] No such file or directo

Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-09-13 Thread Martin Kosek
On Tue, 2011-09-13 at 16:22 +0300, Alexander Bokovoy wrote: > On Tue, 13 Sep 2011, Martin Kosek wrote: > > > So this patch is unblocked. To solve delayed data initialization from > > > SSSD in NSS responder we might simply increase number of tries to 10 > > > in case SSSD is in use. > > That soun

Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-09-13 Thread Alexander Bokovoy
On Tue, 13 Sep 2011, Stephen Gallagher wrote: > > > File "/usr/lib/python2.7/site-packages/SSSDConfig.py", line 1207, in > > > import_config > > > fd = open(configfile, 'r') > > > IOError: [Errno 2] No such file or directory: '/etc/sssd/sssd.conf' > > Right, we need to fallback to new sssd.c

Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-09-13 Thread Stephen Gallagher
On Tue, 2011-09-13 at 16:22 +0300, Alexander Bokovoy wrote: > On Tue, 13 Sep 2011, Martin Kosek wrote: > > > So this patch is unblocked. To solve delayed data initialization from > > > SSSD in NSS responder we might simply increase number of tries to 10 > > > in case SSSD is in use. > > That soun

Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-09-13 Thread Alexander Bokovoy
On Tue, 13 Sep 2011, Martin Kosek wrote: > > So this patch is unblocked. To solve delayed data initialization from > > SSSD in NSS responder we might simply increase number of tries to 10 > > in case SSSD is in use. > That sounds good. I made few tests of this patch and I still see a > problem he

Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-09-13 Thread Stephen Gallagher
On Tue, 2011-09-13 at 15:08 +0200, Martin Kosek wrote: > On Tue, 2011-09-13 at 15:11 +0300, Alexander Bokovoy wrote: > > On Thu, 08 Sep 2011, Alexander Bokovoy wrote: > > > > > On Wed, 07 Sep 2011, Stephen Gallagher wrote: > > > > > > > On Wed, 2011-09-07 at 16:15 +0300, Alexander Bokovoy wrote:

Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-09-13 Thread Martin Kosek
On Tue, 2011-09-13 at 15:11 +0300, Alexander Bokovoy wrote: > On Thu, 08 Sep 2011, Alexander Bokovoy wrote: > > > On Wed, 07 Sep 2011, Stephen Gallagher wrote: > > > > > On Wed, 2011-09-07 at 16:15 +0300, Alexander Bokovoy wrote: > > > > Hi! > > > > > > > > When modifying SSSD configuration, att

Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-09-13 Thread Alexander Bokovoy
On Thu, 08 Sep 2011, Alexander Bokovoy wrote: > On Wed, 07 Sep 2011, Stephen Gallagher wrote: > > > On Wed, 2011-09-07 at 16:15 +0300, Alexander Bokovoy wrote: > > > Hi! > > > > > > When modifying SSSD configuration, attempt to add new domain rather > > > than replacing whole configuration file

Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-09-08 Thread Alexander Bokovoy
On Wed, 07 Sep 2011, Stephen Gallagher wrote: > On Wed, 2011-09-07 at 16:15 +0300, Alexander Bokovoy wrote: > > Hi! > > > > When modifying SSSD configuration, attempt to add new domain rather > > than replacing whole configuration file. > > > > Only replace file in case it is impossible to pars

Re: [Freeipa-devel] [PATCH] 0012 Modify existing SSSD configuration instead of dropping it

2011-09-07 Thread Stephen Gallagher
On Wed, 2011-09-07 at 16:15 +0300, Alexander Bokovoy wrote: > Hi! > > When modifying SSSD configuration, attempt to add new domain rather > than replacing whole configuration file. > > Only replace file in case it is impossible to parse it by current SSSD > version. > > https://fedorahosted.or