Re: [Freeipa-devel] [PATCH] 0031 ipa-restore: Check if directory is provided + better errors.

2014-11-24 Thread Petr Viktorin
On 11/21/2014 02:28 PM, David Kupka wrote: On 11/21/2014 02:12 PM, Tomas Babej wrote: On 11/21/2014 01:56 PM, David Kupka wrote: [...] On another note, I also noticed that read_header leaves leaking file descriptor fd. Can you convert that part to use the with statement? This is a perfect

Re: [Freeipa-devel] [PATCH] 0031 ipa-restore: Check if directory is provided + better errors.

2014-11-21 Thread Tomas Babej
On 11/21/2014 02:28 PM, David Kupka wrote: > On 11/21/2014 02:12 PM, Tomas Babej wrote: >> >> On 11/21/2014 01:56 PM, David Kupka wrote: >>> On 11/21/2014 01:42 PM, Tomas Babej wrote: On 11/21/2014 01:33 PM, David Kupka wrote: > https://fedorahosted.org/freeipa/ticket/4683 >

Re: [Freeipa-devel] [PATCH] 0031 ipa-restore: Check if directory is provided + better errors.

2014-11-21 Thread David Kupka
On 11/21/2014 02:12 PM, Tomas Babej wrote: On 11/21/2014 01:56 PM, David Kupka wrote: On 11/21/2014 01:42 PM, Tomas Babej wrote: On 11/21/2014 01:33 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4683 ___ Freeipa-devel mailing lis

Re: [Freeipa-devel] [PATCH] 0031 ipa-restore: Check if directory is provided + better errors.

2014-11-21 Thread Tomas Babej
On 11/21/2014 01:56 PM, David Kupka wrote: > On 11/21/2014 01:42 PM, Tomas Babej wrote: >> >> On 11/21/2014 01:33 PM, David Kupka wrote: >>> https://fedorahosted.org/freeipa/ticket/4683 >>> >>> >>> ___ >>> Freeipa-devel mailing list >>> Freeipa-devel@red

Re: [Freeipa-devel] [PATCH] 0031 ipa-restore: Check if directory is provided + better errors.

2014-11-21 Thread David Kupka
On 11/21/2014 01:42 PM, Tomas Babej wrote: On 11/21/2014 01:33 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4683 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel -

Re: [Freeipa-devel] [PATCH] 0031 ipa-restore: Check if directory is provided + better errors.

2014-11-21 Thread Tomas Babej
On 11/21/2014 01:33 PM, David Kupka wrote: > https://fedorahosted.org/freeipa/ticket/4683 > > > ___ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel -self.read_header() +