Re: [Freeipa-devel] [PATCH] 0045-47: webui: Sub-CAs

2016-06-15 Thread Martin Basti
On 14.06.2016 18:30, Petr Vobornik wrote: On 06/14/2016 10:17 AM, Pavel Vomacka wrote: On 06/14/2016 06:42 AM, Fraser Tweedale wrote: On Mon, Jun 13, 2016 at 07:48:58PM +0200, Pavel Vomacka wrote: On 06/13/2016 06:55 AM, Fraser Tweedale wrote: On Fri, Jun 10, 2016 at 04:34:33PM +0200,

Re: [Freeipa-devel] [PATCH] 0045-47: webui: Sub-CAs

2016-06-14 Thread Petr Vobornik
On 06/14/2016 10:17 AM, Pavel Vomacka wrote: > > > On 06/14/2016 06:42 AM, Fraser Tweedale wrote: >> On Mon, Jun 13, 2016 at 07:48:58PM +0200, Pavel Vomacka wrote: >>> >>> On 06/13/2016 06:55 AM, Fraser Tweedale wrote: On Fri, Jun 10, 2016 at 04:34:33PM +0200, Pavel Vomacka wrote: >

Re: [Freeipa-devel] [PATCH] 0045-47: webui: Sub-CAs

2016-06-14 Thread Pavel Vomacka
On 06/14/2016 06:42 AM, Fraser Tweedale wrote: On Mon, Jun 13, 2016 at 07:48:58PM +0200, Pavel Vomacka wrote: On 06/13/2016 06:55 AM, Fraser Tweedale wrote: On Fri, Jun 10, 2016 at 04:34:33PM +0200, Pavel Vomacka wrote: Hello, please review these new patches which add WebUI for Sub-CAs.

Re: [Freeipa-devel] [PATCH] 0045-47: webui: Sub-CAs

2016-06-13 Thread Fraser Tweedale
On Mon, Jun 13, 2016 at 07:48:58PM +0200, Pavel Vomacka wrote: > > > On 06/13/2016 06:55 AM, Fraser Tweedale wrote: > > On Fri, Jun 10, 2016 at 04:34:33PM +0200, Pavel Vomacka wrote: > > > Hello, > > > > > > please review these new patches which add WebUI for Sub-CAs. > > > > > >

Re: [Freeipa-devel] [PATCH] 0045-47: webui: Sub-CAs

2016-06-13 Thread Pavel Vomacka
On 06/13/2016 06:55 AM, Fraser Tweedale wrote: On Fri, Jun 10, 2016 at 04:34:33PM +0200, Pavel Vomacka wrote: Hello, please review these new patches which add WebUI for Sub-CAs. https://fedorahosted.org/freeipa/ticket/5939 Hi Pavel, I have reviewed the functionality of the patches.

Re: [Freeipa-devel] [PATCH] 0045-47: webui: Sub-CAs

2016-06-12 Thread Fraser Tweedale
On Fri, Jun 10, 2016 at 04:34:33PM +0200, Pavel Vomacka wrote: > Hello, > > please review these new patches which add WebUI for Sub-CAs. > > https://fedorahosted.org/freeipa/ticket/5939 > Hi Pavel, I have reviewed the functionality of the patches. Functionality is good - a few minor comments