Re: [Freeipa-devel] [PATCH] 0045 Expose ipaRangeType in Web UI

2013-07-29 Thread Petr Vobornik
On 07/26/2013 05:54 PM, Ana Krivokapic wrote: On 07/17/2013 01:53 PM, Petr Vobornik wrote: On 07/16/2013 06:46 PM, Ana Krivokapic wrote: Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3759. Hello, Thanks for the patch, some comments: 1) idrange.js:183 I would

Re: [Freeipa-devel] [PATCH] 0045 Expose ipaRangeType in Web UI

2013-07-29 Thread Ana Krivokapic
On 07/29/2013 10:08 AM, Petr Vobornik wrote: On 07/26/2013 05:54 PM, Ana Krivokapic wrote: On 07/17/2013 01:53 PM, Petr Vobornik wrote: On 07/16/2013 06:46 PM, Ana Krivokapic wrote: Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3759. Hello, Thanks for the

Re: [Freeipa-devel] [PATCH] 0045 Expose ipaRangeType in Web UI

2013-07-29 Thread Petr Vobornik
On 07/29/2013 10:31 AM, Ana Krivokapic wrote: On 07/29/2013 10:08 AM, Petr Vobornik wrote: On 07/26/2013 05:54 PM, Ana Krivokapic wrote: On 07/17/2013 01:53 PM, Petr Vobornik wrote: On 07/16/2013 06:46 PM, Ana Krivokapic wrote: Hello, This patch addresses ticket

Re: [Freeipa-devel] [PATCH] 0045 Expose ipaRangeType in Web UI

2013-07-26 Thread Ana Krivokapic
On 07/17/2013 01:53 PM, Petr Vobornik wrote: On 07/16/2013 06:46 PM, Ana Krivokapic wrote: Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3759. Hello, Thanks for the patch, some comments: 1) idrange.js:183 I would avoid modifying widget html output in form

Re: [Freeipa-devel] [PATCH] 0045 Expose ipaRangeType in Web UI

2013-07-17 Thread Petr Vobornik
On 07/16/2013 06:46 PM, Ana Krivokapic wrote: Hello, This patch addresses ticket https://fedorahosted.org/freeipa/ticket/3759. Hello, Thanks for the patch, some comments: 1) idrange.js:183 I would avoid modifying widget html output in form methods. In this case you can simply add `layout: