Re: [Freeipa-devel] [PATCH] 0065 Use ldapi with krb5kdc

2011-01-20 Thread Simo Sorce
On Thu, 20 Jan 2011 19:24:59 +
JR Aquino  wrote:

> Patch works correctly.
> 
> ACK

thanks,
pushed to master.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 0065 Use ldapi with krb5kdc

2011-01-20 Thread JR Aquino
On 1/20/11 10:11 AM, "Rob Crittenden"  wrote:

>JR Aquino wrote:
>> NACK.
>>
>> Please retest this... I'm not sure how it is related, but I receive an
>> error during the make rpm process:
>>
>> Traceback (most recent call last):
>>File "./makeapi", line 27, in
>>  from ipalib import *
>>File
>> 
>>"/usr/src/freeipa/rpmbuild/BUILD/freeipa-2.0.0GITb9ad279/ipalib/__init__.
>>py
>> ", line 878, in
>>  from frontend import Command, LocalOrRemote
>>File
>> 
>>"/usr/src/freeipa/rpmbuild/BUILD/freeipa-2.0.0GITb9ad279/ipalib/frontend.
>>py
>> ", line 36, in
>>  from ipapython.version import API_VERSION
>>File
>> 
>>"/usr/src/freeipa/rpmbuild/BUILD/freeipa-2.0.0GITb9ad279/ipapython/versio
>>n.
>> py", line 25, in
>>  NUM_VERSION=200
>> NameError: name '__NUM_VERSION__' is not defined
>> make[1]: *** [version-update] Error 1
>> make[1]: Leaving directory
>> `/usr/src/freeipa/rpmbuild/BUILD/freeipa-2.0.0GITb9ad279'
>> error: Bad exit status from /var/tmp/rpm-tmp.315pIJ (%build)
>>
>>
>> RPM build errors:
>>  Bad exit status from /var/tmp/rpm-tmp.315pIJ (%build)
>> make: *** [rpms] Error 1
>
>This error is unrelated though I'm unsure what is broken. The first
>thing the build should do is run the version-update target which will do
>substitutions in ipapython/version.py.in into ipapython/version.py. It
>seems that didn't happen or is otherwise broke. Can you see if
>version-update is being called by make?
>
>rob

Thank you for catching that Rob!

This was unrelated.  Did a full remove and a new clone.

Patch works correctly.

ACK



___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 0065 Use ldapi with krb5kdc

2011-01-20 Thread Rob Crittenden

JR Aquino wrote:

NACK.

Please retest this... I'm not sure how it is related, but I receive an
error during the make rpm process:

Traceback (most recent call last):
   File "./makeapi", line 27, in
 from ipalib import *
   File
"/usr/src/freeipa/rpmbuild/BUILD/freeipa-2.0.0GITb9ad279/ipalib/__init__.py
", line 878, in
 from frontend import Command, LocalOrRemote
   File
"/usr/src/freeipa/rpmbuild/BUILD/freeipa-2.0.0GITb9ad279/ipalib/frontend.py
", line 36, in
 from ipapython.version import API_VERSION
   File
"/usr/src/freeipa/rpmbuild/BUILD/freeipa-2.0.0GITb9ad279/ipapython/version.
py", line 25, in
 NUM_VERSION=200
NameError: name '__NUM_VERSION__' is not defined
make[1]: *** [version-update] Error 1
make[1]: Leaving directory
`/usr/src/freeipa/rpmbuild/BUILD/freeipa-2.0.0GITb9ad279'
error: Bad exit status from /var/tmp/rpm-tmp.315pIJ (%build)


RPM build errors:
 Bad exit status from /var/tmp/rpm-tmp.315pIJ (%build)
make: *** [rpms] Error 1


This error is unrelated though I'm unsure what is broken. The first 
thing the build should do is run the version-update target which will do 
substitutions in ipapython/version.py.in into ipapython/version.py. It 
seems that didn't happen or is otherwise broke. Can you see if 
version-update is being called by make?


rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 0065 Use ldapi with krb5kdc

2011-01-20 Thread JR Aquino
NACK.

Please retest this... I'm not sure how it is related, but I receive an
error during the make rpm process:

Traceback (most recent call last):
  File "./makeapi", line 27, in 
from ipalib import *
  File 
"/usr/src/freeipa/rpmbuild/BUILD/freeipa-2.0.0GITb9ad279/ipalib/__init__.py
", line 878, in 
from frontend import Command, LocalOrRemote
  File 
"/usr/src/freeipa/rpmbuild/BUILD/freeipa-2.0.0GITb9ad279/ipalib/frontend.py
", line 36, in 
from ipapython.version import API_VERSION
  File 
"/usr/src/freeipa/rpmbuild/BUILD/freeipa-2.0.0GITb9ad279/ipapython/version.
py", line 25, in 
NUM_VERSION=200
NameError: name '__NUM_VERSION__' is not defined
make[1]: *** [version-update] Error 1
make[1]: Leaving directory
`/usr/src/freeipa/rpmbuild/BUILD/freeipa-2.0.0GITb9ad279'
error: Bad exit status from /var/tmp/rpm-tmp.315pIJ (%build)


RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.315pIJ (%build)
make: *** [rpms] Error 1



On 1/19/11 4:11 PM, "Simo Sorce"  wrote:

>
>Long ago we decided to use the ldapi socket to let the KDC access the
>ldap data in order to avoid comunication over the network (even if it
>is 127.0.0.1).
>
>This patch finally implements that. Although beware that this patch
>will need you to either create custom policy or to set selinux in
>permissive mode until the new policy lands in fedora land.
>
>Bugs have been opened and I think the policy has already landed in
>rawhide.
>
>Simo.
>
>-- 
>Simo Sorce * Red Hat, Inc * New York
>___
>Freeipa-devel mailing list
>Freeipa-devel@redhat.com
>https://www.redhat.com/mailman/listinfo/freeipa-devel


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel