Re: [Freeipa-devel] [PATCH] 0074 jslint cleanup

2010-11-03 Thread Adam Young
On 11/03/2010 02:20 PM, Adam Young wrote: On 11/03/2010 01:15 PM, Endi Sukma Dewata wrote: On 11/3/2010 9:10 AM, Adam Young wrote: The IPA and ipa_cmd are defined twice. +var IPA; +var ipa_cmd; +var IPA = ( function () { function ipa_cmd(name, args, options, win_callback, fail_callback, objna

Re: [Freeipa-devel] [PATCH] 0074 jslint cleanup

2010-11-03 Thread Endi Sukma Dewata
On 11/3/2010 1:20 PM, Adam Young wrote: Note the comment about "Forward declared" jslint complains if there is no forward declaration. I've postponed moving ipa_cmd into the IPA namespace in this patch, as that will cause a ripple effect through the rest of the .js files. I've seen several ways

Re: [Freeipa-devel] [PATCH] 0074 jslint cleanup

2010-11-03 Thread Adam Young
On 11/03/2010 01:15 PM, Endi Sukma Dewata wrote: On 11/3/2010 9:10 AM, Adam Young wrote: The IPA and ipa_cmd are defined twice. +var IPA; +var ipa_cmd; +var IPA = ( function () { function ipa_cmd(name, args, options, win_callback, fail_callback, objname) Fixed The duplicate IPA declaratio

Re: [Freeipa-devel] [PATCH] 0074 jslint cleanup

2010-11-03 Thread Endi Sukma Dewata
On 11/3/2010 9:10 AM, Adam Young wrote: The IPA and ipa_cmd are defined twice. +var IPA; +var ipa_cmd; +var IPA = ( function () { function ipa_cmd(name, args, options, win_callback, fail_callback, objname) Fixed The duplicate IPA declaration is fixed, but the ipa_cmd is still declared twic

Re: [Freeipa-devel] [PATCH] 0074 jslint cleanup

2010-11-03 Thread Adam Young
On 11/03/2010 08:33 AM, Endi Sukma Dewata wrote: On 11/2/2010 2:33 PM, Adam Young wrote: While this doesn't fix all of the jslint complaints for ipa.js, it fixes the worst offenders. Nearly ACKed... is there such thing? :) The IPA and ipa_cmd are defined twice. +var IPA; +var ipa_cmd; +var

Re: [Freeipa-devel] [PATCH] 0074 jslint cleanup

2010-11-03 Thread Endi Sukma Dewata
On 11/2/2010 2:33 PM, Adam Young wrote: While this doesn't fix all of the jslint complaints for ipa.js, it fixes the worst offenders. Nearly ACKed... is there such thing? :) The IPA and ipa_cmd are defined twice. +var IPA; +var ipa_cmd; +var IPA = ( function () { function ipa_cmd(name, args