Re: [Freeipa-devel] [PATCH] 0082 cert-request: better error msg when 'add' not supported

2016-06-30 Thread Martin Basti
On 30.06.2016 15:16, Florence Blanc-Renaud wrote: On 06/30/2016 01:30 PM, Fraser Tweedale wrote: On Thu, Jun 30, 2016 at 07:49:04PM +1000, Fraser Tweedale wrote: On Thu, Jun 30, 2016 at 11:38:35AM +0200, Florence Blanc-Renaud wrote: On 06/30/2016 06:29 AM, Fraser Tweedale wrote: On Wed, Jun

Re: [Freeipa-devel] [PATCH] 0082 cert-request: better error msg when 'add' not supported

2016-06-30 Thread Florence Blanc-Renaud
On 06/30/2016 01:30 PM, Fraser Tweedale wrote: On Thu, Jun 30, 2016 at 07:49:04PM +1000, Fraser Tweedale wrote: On Thu, Jun 30, 2016 at 11:38:35AM +0200, Florence Blanc-Renaud wrote: On 06/30/2016 06:29 AM, Fraser Tweedale wrote: On Wed, Jun 29, 2016 at 11:30:14AM +0200, Florence Blanc-Renaud

Re: [Freeipa-devel] [PATCH] 0082 cert-request: better error msg when 'add' not supported

2016-06-30 Thread Fraser Tweedale
On Thu, Jun 30, 2016 at 07:49:04PM +1000, Fraser Tweedale wrote: > On Thu, Jun 30, 2016 at 11:38:35AM +0200, Florence Blanc-Renaud wrote: > > On 06/30/2016 06:29 AM, Fraser Tweedale wrote: > > > On Wed, Jun 29, 2016 at 11:30:14AM +0200, Florence Blanc-Renaud wrote: > > > > On 06/29/2016 07:25 AM, F

Re: [Freeipa-devel] [PATCH] 0082 cert-request: better error msg when 'add' not supported

2016-06-30 Thread Fraser Tweedale
On Thu, Jun 30, 2016 at 11:38:35AM +0200, Florence Blanc-Renaud wrote: > On 06/30/2016 06:29 AM, Fraser Tweedale wrote: > > On Wed, Jun 29, 2016 at 11:30:14AM +0200, Florence Blanc-Renaud wrote: > > > On 06/29/2016 07:25 AM, Fraser Tweedale wrote: > > > > The attached patch fixes > > > > https://fe

Re: [Freeipa-devel] [PATCH] 0082 cert-request: better error msg when 'add' not supported

2016-06-30 Thread Florence Blanc-Renaud
On 06/30/2016 06:29 AM, Fraser Tweedale wrote: On Wed, Jun 29, 2016 at 11:30:14AM +0200, Florence Blanc-Renaud wrote: On 06/29/2016 07:25 AM, Fraser Tweedale wrote: The attached patch fixes https://fedorahosted.org/freeipa/ticket/5991. Thanks, Fraser Hi Fraser, A few cosmetic comments: P

Re: [Freeipa-devel] [PATCH] 0082 cert-request: better error msg when 'add' not supported

2016-06-29 Thread Fraser Tweedale
On Wed, Jun 29, 2016 at 11:30:14AM +0200, Florence Blanc-Renaud wrote: > On 06/29/2016 07:25 AM, Fraser Tweedale wrote: > > The attached patch fixes > > https://fedorahosted.org/freeipa/ticket/5991. > > > > Thanks, > > Fraser > > > > > > > Hi Fraser, > > A few cosmetic comments: > > PEP8 issu

Re: [Freeipa-devel] [PATCH] 0082 cert-request: better error msg when 'add' not supported

2016-06-29 Thread Florence Blanc-Renaud
On 06/29/2016 07:25 AM, Fraser Tweedale wrote: The attached patch fixes https://fedorahosted.org/freeipa/ticket/5991. Thanks, Fraser Hi Fraser, A few cosmetic comments: PEP8 issues: ./ipalib/errors.py:1399:1: E302 expected 2 blank lines, found 1 ./ipaserver/plugins/cert.py:394:80: E501 lin