Re: [Freeipa-devel] [PATCH] 0087 Fix an integer underflow bug in libotp

2015-09-29 Thread Tomas Babej
On 09/29/2015 01:57 PM, Tomas Babej wrote: > > On 09/25/2015 06:38 PM, Nathaniel McCallum wrote: >> On Fri, 2015-09-25 at 12:18 -0400, Nathaniel McCallum wrote: >>> Temporarily storing the offset time in an unsigned integer causes the >>> value of the offset to underflow when a (valid) negative

Re: [Freeipa-devel] [PATCH] 0087 Fix an integer underflow bug in libotp

2015-09-29 Thread Tomas Babej
On 09/29/2015 03:10 PM, Tomas Babej wrote: > > > On 09/29/2015 01:57 PM, Tomas Babej wrote: >> >> On 09/25/2015 06:38 PM, Nathaniel McCallum wrote: >>> On Fri, 2015-09-25 at 12:18 -0400, Nathaniel McCallum wrote: Temporarily storing the offset time in an unsigned integer causes the

Re: [Freeipa-devel] [PATCH] 0087 Fix an integer underflow bug in libotp

2015-09-29 Thread Tomas Babej
On 09/25/2015 06:38 PM, Nathaniel McCallum wrote: > On Fri, 2015-09-25 at 12:18 -0400, Nathaniel McCallum wrote: >> Temporarily storing the offset time in an unsigned integer causes the >> value of the offset to underflow when a (valid) negative offset value >> is generated. Using a signed

Re: [Freeipa-devel] [PATCH] 0087 Fix an integer underflow bug in libotp

2015-09-25 Thread Nathaniel McCallum
On Fri, 2015-09-25 at 12:18 -0400, Nathaniel McCallum wrote: > Temporarily storing the offset time in an unsigned integer causes the > value of the offset to underflow when a (valid) negative offset value > is generated. Using a signed variable avoids this problem. This new version makes the