Re: [Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-29 Thread Endi Sukma Dewata
On 11/25/2010 8:24 PM, Adam Young wrote: Updated version that doesn't break SUDO or HBAC. The third level nesting in the tabs set is only used for this kind of navigation now, but should be used for Action panel shortly. Conditional ACK... :) There are some additional changes that need to be

Re: [Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-29 Thread Endi Sukma Dewata
On 11/29/2010 12:08 PM, Endi Sukma Dewata wrote: On 11/25/2010 8:24 PM, Adam Young wrote: Updated version that doesn't break SUDO or HBAC. The third level nesting in the tabs set is only used for this kind of navigation now, but should be used for Action panel shortly. Conditional ACK... :)

Re: [Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-25 Thread Adam Young
Updated version that doesn't break SUDO or HBAC. The third level nesting in the tabs set is only used for this kind of navigation now, but should be used for Action panel shortly. From 2371a5b82d7f3184445bcbba32ca516747bb9c6e Mon Sep 17 00:00:00 2001 From: Adam Young ayo...@redhat.com Date:

Re: [Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-23 Thread Adam Young
On 11/23/2010 02:15 PM, Endi Sukma Dewata wrote: On 11/22/2010 10:41 AM, Adam Young wrote: Without reordering things now, I propose we allow for a three level structure in the tab_set. Top level will not be an entity. Second level will be an entity. third level will be a nested entity.

Re: [Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-22 Thread Adam Young
On 11/19/2010 06:53 PM, Endi Sukma Dewata wrote: On 11/19/2010 4:09 PM, Adam Young wrote: This will not work with entities that do not have associated tabs, e.g. hbacsvc, hbacsvcgroups, sudocmd, sudocmdgroups. For these entities the IPA.tab_state() will return undefined, so the

Re: [Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-22 Thread Dmitri Pal
Adam Young wrote: On 11/19/2010 06:53 PM, Endi Sukma Dewata wrote: On 11/19/2010 4:09 PM, Adam Young wrote: This will not work with entities that do not have associated tabs, e.g. hbacsvc, hbacsvcgroups, sudocmd, sudocmdgroups. For these entities the IPA.tab_state() will return undefined,

Re: [Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-22 Thread Dmitri Pal
Dmitri Pal wrote: Adam Young wrote: On 11/19/2010 06:53 PM, Endi Sukma Dewata wrote: On 11/19/2010 4:09 PM, Adam Young wrote: This will not work with entities that do not have associated tabs, e.g. hbacsvc, hbacsvcgroups, sudocmd, sudocmdgroups. For these entities the

Re: [Freeipa-devel] [PATCH] 0100-top-nav-index

2010-11-19 Thread Endi Sukma Dewata
On 11/19/2010 4:09 PM, Adam Young wrote: This will not work with entities that do not have associated tabs, e.g. hbacsvc, hbacsvcgroups, sudocmd, sudocmdgroups. For these entities the IPA.tab_state() will return undefined, so the ipa_column_widget.setup() will fail. To reproduce this