Re: [Freeipa-devel] [PATCH] 0108 Add support for compatibility tree for trusted domain users

2013-07-18 Thread Martin Kosek
On 07/18/2013 05:45 PM, Alexander Bokovoy wrote: > On Tue, 16 Jul 2013, Jakub Hrozek wrote: >>> >>+if self.enable_compat: >>> >>+self.step("Enabling trusted domains support for older clients >>> via Schema Compatibility plugin", >>> > >>> > >>> >

Re: [Freeipa-devel] [PATCH] 0108 Add support for compatibility tree for trusted domain users

2013-07-18 Thread Alexander Bokovoy
On Tue, 16 Jul 2013, Jakub Hrozek wrote: >>+if self.enable_compat: >>+self.step("Enabling trusted domains support for older clients via Schema Compatibility plugin", > > > Nitpick: all the other steps begin with lowercased >

Re: [Freeipa-devel] [PATCH] 0108 Add support for compatibility tree for trusted domain users

2013-07-16 Thread Jakub Hrozek
On Tue, Jul 16, 2013 at 04:22:01PM +0300, Alexander Bokovoy wrote: > On Tue, 16 Jul 2013, Jakub Hrozek wrote: > >the patch looks mostly good to me. I only have some small nitpicks: > > > >>+++ b/install/tools/man/ipa-adtrust-install.1 > >>@@ -106,6 +106,24 @@ The password of the user with administr

Re: [Freeipa-devel] [PATCH] 0108 Add support for compatibility tree for trusted domain users

2013-07-16 Thread Alexander Bokovoy
On Tue, 16 Jul 2013, Jakub Hrozek wrote: the patch looks mostly good to me. I only have some small nitpicks: +++ b/install/tools/man/ipa-adtrust-install.1 @@ -106,6 +106,24 @@ The password of the user with administrative privileges for this IPA server. Wil .TP The credentials of the admin us

Re: [Freeipa-devel] [PATCH] 0108 Add support for compatibility tree for trusted domain users

2013-07-16 Thread Jakub Hrozek
On Mon, Jul 15, 2013 at 08:14:52PM +0300, Alexander Bokovoy wrote: > Hi! > > Attached patch allows to enable serving trusted domain users and groups > through Schema Compatibilty plugin. > > The patch only does FreeIPA master configuration settings, the real work > is done by the changes to slapi