Re: [Freeipa-devel] [PATCH] 0133 Use standard_list_of_entries for trust-resolve

2014-01-16 Thread Petr Viktorin
On 01/15/2014 06:24 PM, Alexander Bokovoy wrote: [...] Thanks to Sumit, here is updated patch because I forgot to run makeapi ;( :) You should tell the computer to remind you next time :) For the record, I have this in my .git/hooks/post-commit: ./makeapi git status --short Runs makeapi,

Re: [Freeipa-devel] [PATCH] 0133 Use standard_list_of_entries for trust-resolve

2014-01-15 Thread Alexander Bokovoy
On Wed, 15 Jan 2014, Alexander Bokovoy wrote: Hi! When looking into https://fedorahosted.org/freeipa/ticket/4113, I decided to use output.standard_list_of_entries instead of a locally defined list of entries. This solves the problem with wrong exit code in CLI when non-resolvable SID is given,

Re: [Freeipa-devel] [PATCH] 0133 Use standard_list_of_entries for trust-resolve

2014-01-15 Thread Sumit Bose
On Wed, Jan 15, 2014 at 07:24:00PM +0200, Alexander Bokovoy wrote: On Wed, 15 Jan 2014, Alexander Bokovoy wrote: Hi! When looking into https://fedorahosted.org/freeipa/ticket/4113, I decided to use output.standard_list_of_entries instead of a locally defined list of entries. This solves the

Re: [Freeipa-devel] [PATCH] 0133 Use standard_list_of_entries for trust-resolve

2014-01-15 Thread Alexander Bokovoy
On Wed, 15 Jan 2014, Sumit Bose wrote: On Wed, Jan 15, 2014 at 07:24:00PM +0200, Alexander Bokovoy wrote: On Wed, 15 Jan 2014, Alexander Bokovoy wrote: Hi! When looking into https://fedorahosted.org/freeipa/ticket/4113, I decided to use output.standard_list_of_entries instead of a locally

Re: [Freeipa-devel] [PATCH] 0133 Use standard_list_of_entries for trust-resolve

2014-01-15 Thread Martin Kosek
- Original Message - From: Alexander Bokovoy aboko...@redhat.com To: Sumit Bose sb...@redhat.com Cc: freeipa-devel@redhat.com Sent: Wednesday, January 15, 2014 7:00:57 PM Subject: Re: [Freeipa-devel] [PATCH] 0133 Use standard_list_of_entries for trust-resolve On Wed, 15 Jan 2014

Re: [Freeipa-devel] [PATCH] 0133 Use standard_list_of_entries for trust-resolve

2014-01-15 Thread Alexander Bokovoy
On Wed, 15 Jan 2014, Martin Kosek wrote: - Original Message - From: Alexander Bokovoy aboko...@redhat.com To: Sumit Bose sb...@redhat.com Cc: freeipa-devel@redhat.com Sent: Wednesday, January 15, 2014 7:00:57 PM Subject: Re: [Freeipa-devel] [PATCH] 0133 Use standard_list_of_entries

Re: [Freeipa-devel] [PATCH] 0133 Use standard_list_of_entries for trust-resolve

2014-01-15 Thread Alexander Bokovoy
On Wed, 15 Jan 2014, Alexander Bokovoy wrote: I am personally not convinced this is the right way to fix #4113, for several reasons: 1) The output modification will most probably break FreeIPA 3.2.x or FreeIPA 3.3.x clients who expect different output (the command was introduced in