Re: [Freeipa-devel] [PATCH] 0227-2-automount-UI

2011-05-26 Thread Endi Sukma Dewata
On 5/25/2011 7:58 PM, Adam Young wrote: 17. The adder dialog boxes for map and key don't have a title. The titles should be defined in internal.py and the ipa_init.json needs to be regenerated. Fixed The ipa_init.json doesn't seem to be updated yet. More changes in this patch. I combined

Re: [Freeipa-devel] [PATCH] 0227-2-automount-UI

2011-05-26 Thread Adam Young
On 05/26/2011 09:30 AM, Endi Sukma Dewata wrote: On 5/25/2011 7:58 PM, Adam Young wrote: 17. The adder dialog boxes for map and key don't have a title. The titles should be defined in internal.py and the ipa_init.json needs to be regenerated. Fixed The ipa_init.json doesn't seem to be

Re: [Freeipa-devel] [PATCH] 0227-2-automount-UI

2011-05-25 Thread Adam Young
On 05/25/2011 12:28 AM, Endi Sukma Dewata wrote: On 5/24/2011 5:32 PM, Adam Young wrote: On 05/24/2011 05:06 PM, Endi Sukma Dewata wrote: On 5/24/2011 1:11 PM, Adam Young wrote: Known issues: the back to list links are broken. Add and delete for keys not working due to API issues discussed

Re: [Freeipa-devel] [PATCH] 0227-2-automount-UI

2011-05-25 Thread Adam Young
On 05/25/2011 12:28 AM, Endi Sukma Dewata wrote: 10. The code assumes that the primary keys will be specified as command arguments, which we know doesn't match the API for automount keys. Suppose we decide not to change the API, there should be a way to invoke the current API

Re: [Freeipa-devel] [PATCH] 0227-2-automount-UI

2011-05-25 Thread Endi Sukma Dewata
On 5/25/2011 11:31 AM, Adam Young wrote: 8. The column in the maps search facet doesn't have a title. Done. This actually was an indication of a deeper problem, that the columns were pointing to the wrong entity for param info. This is because the nested_search_facet is defined in the

Re: [Freeipa-devel] [PATCH] 0227-2-automount-UI

2011-05-25 Thread Endi Sukma Dewata
A few more minor problems: On 5/25/2011 2:54 PM, Adam Young wrote: 12. The automount map has a description field which can be specified during add modify. The UI doesn't have this. Fixed It's still missing from the map's adder dialog box. 17. The adder dialog boxes for map and key don't

Re: [Freeipa-devel] [PATCH] 0227-2-automount-UI

2011-05-24 Thread Endi Sukma Dewata
On 5/24/2011 1:11 PM, Adam Young wrote: Known issues: the back to list links are broken. Add and delete for keys not working due to API issues discussed elsewhere. Some issues: 1. The 3rd level tabs (Location, Maps, Keys) can be removed because there's already a breadcrumb which provides

Re: [Freeipa-devel] [PATCH] 0227-2-automount-UI

2011-05-24 Thread Endi Sukma Dewata
On 5/24/2011 5:32 PM, Adam Young wrote: On 05/24/2011 05:06 PM, Endi Sukma Dewata wrote: On 5/24/2011 1:11 PM, Adam Young wrote: Known issues: the back to list links are broken. Add and delete for keys not working due to API issues discussed elsewhere. 1. The 3rd level tabs (Location, Maps,