On 7/8/2011 10:06 AM, Adam Young wrote:
Some issues:
1. The new code in IPA.widget.test_dirty() seems to be redundant.
if ((that.values.length === 0)
(values.length === 1)
values[0] === ){
return false;
}
It's already covered by a similar code above it.
On 07/08/2011 12:40 PM, Endi Sukma Dewata wrote:
On 7/8/2011 10:06 AM, Adam Young wrote:
Some issues:
1. The new code in IPA.widget.test_dirty() seems to be redundant.
if ((that.values.length === 0)
(values.length === 1)
values[0] === ){
return false;
}
On 07/08/2011 01:00 PM, Adam Young wrote:
On 07/08/2011 12:40 PM, Endi Sukma Dewata wrote:
On 7/8/2011 10:06 AM, Adam Young wrote:
Some issues:
1. The new code in IPA.widget.test_dirty() seems to be redundant.
if ((that.values.length === 0)
(values.length === 1)
On 07/08/2011 01:02 PM, Adam Young wrote:
On 07/08/2011 01:00 PM, Adam Young wrote:
On 07/08/2011 12:40 PM, Endi Sukma Dewata wrote:
On 7/8/2011 10:06 AM, Adam Young wrote:
Some issues:
1. The new code in IPA.widget.test_dirty() seems to be redundant.
if ((that.values.length === 0)
On 07/08/2011 01:25 PM, Adam Young wrote:
On 07/08/2011 01:02 PM, Adam Young wrote:
On 07/08/2011 01:00 PM, Adam Young wrote:
On 07/08/2011 12:40 PM, Endi Sukma Dewata wrote:
On 7/8/2011 10:06 AM, Adam Young wrote:
Some issues:
1. The new code in IPA.widget.test_dirty() seems to be
On 7/8/2011 12:29 PM, Adam Young wrote:
Removed code in is_dirty check, as it deson't seem to get triggered now.
ACK and pushed to master.
--
Endi S. Dewata
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
