Re: [Freeipa-devel] [PATCH] 031 Remove WebUI identifiers from global namespace

2011-02-18 Thread Adam Young
On 02/18/2011 04:10 AM, Martin Kosek wrote: On Thu, 2011-02-17 at 12:29 -0500, Adam Young wrote: Looks good. Only problem is on braces. we have a code standard that is like this IPA.something = function () { not IPA.something = function () { This is due to Javascript being ambiguous

Re: [Freeipa-devel] [PATCH] 031 Remove WebUI identifiers from global namespace

2011-02-17 Thread Martin Kosek
On Wed, 2011-02-16 at 10:46 -0500, Adam Young wrote: Almost there. I'd like to pull the sudo namespace out of ipa.js and put it into sudorule.js, then indicate that the other sudo files depend on sudo rule. I guess I should have been clearer: stuff like facets and widgets don't

Re: [Freeipa-devel] [PATCH] 031 Remove WebUI identifiers from global namespace

2011-02-17 Thread Adam Young
On 02/17/2011 05:21 AM, Martin Kosek wrote: On Wed, 2011-02-16 at 10:46 -0500, Adam Young wrote: Almost there. I'd like to pull the sudo namespace out of ipa.js and put it into sudorule.js, then indicate that the other sudo files depend on sudo rule. I guess I should have been clearer:

Re: [Freeipa-devel] [PATCH] 031 Remove WebUI identifiers from global namespace

2011-02-16 Thread Adam Young
On 02/16/2011 10:16 AM, Martin Kosek wrote: On Tue, 2011-02-15 at 13:26 -0500, Adam Young wrote: On 02/15/2011 08:25 AM, Martin Kosek wrote: Many WebUI identifiers were defined in a global namespace. This is not a good programming practice and may result in name clashes, for example with other

Re: [Freeipa-devel] [PATCH] 031 Remove WebUI identifiers from global namespace

2011-02-15 Thread Adam Young
On 02/15/2011 08:25 AM, Martin Kosek wrote: Many WebUI identifiers were defined in a global namespace. This is not a good programming practice and may result in name clashes, for example with other libraries. This patch moves these variables to IPA namespace or its sub-namespaces, if required.