Re: [Freeipa-devel] [PATCH] 0481 permission-find: Cache the root entry for legacy permissions
On 03/10/2014 12:05 PM, Petr Viktorin wrote: > On 03/07/2014 04:45 PM, Martin Kosek wrote: >> On 02/28/2014 03:51 PM, Petr Viktorin wrote: >>> Hello, >>> This reduces LDAP searches in permission-find when there are legacy >>> permissions. The root entry (which contains all legacy permission ACIs) is >>> only >>> looked up once. >>> >>> >> >> There is a conflict on one line. But when I manually resolved it, the patch >> worked for me. We got from 176 OPS per "ipa permission-find" to ~96. This >> should be OK for now. >> >> Martin > > I don't see the conflict. Perhaps I mistakenly based this patch on something > that's now pushed (though this applies cleanly to master from a week ago, > too...). > Could you check again? > Ok, I probably simply applied your permission fixes in wrong order. ACK. Pushed to master: 34c3d309d99d0ebe5eb0b935d356e30d8866c139 Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0481 permission-find: Cache the root entry for legacy permissions
On 03/07/2014 04:45 PM, Martin Kosek wrote: On 02/28/2014 03:51 PM, Petr Viktorin wrote: Hello, This reduces LDAP searches in permission-find when there are legacy permissions. The root entry (which contains all legacy permission ACIs) is only looked up once. There is a conflict on one line. But when I manually resolved it, the patch worked for me. We got from 176 OPS per "ipa permission-find" to ~96. This should be OK for now. Martin I don't see the conflict. Perhaps I mistakenly based this patch on something that's now pushed (though this applies cleanly to master from a week ago, too...). Could you check again? -- Petr³ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 0481 permission-find: Cache the root entry for legacy permissions
On 02/28/2014 03:51 PM, Petr Viktorin wrote: > Hello, > This reduces LDAP searches in permission-find when there are legacy > permissions. The root entry (which contains all legacy permission ACIs) is > only > looked up once. > > There is a conflict on one line. But when I manually resolved it, the patch worked for me. We got from 176 OPS per "ipa permission-find" to ~96. This should be OK for now. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
