Re: [Freeipa-devel] [PATCH] 0614 test_ipagetkeytab: Fix expected error message

2014-07-03 Thread Martin Kosek
On 07/03/2014 05:23 PM, Simo Sorce wrote:
> On Wed, 2014-07-02 at 18:32 +0200, Petr Viktorin wrote:
>> It looks like ipa-getkeytab error message for a non-existent service 
>> changed.
>>
>> Simo, is this expected?
> 
> I was asked to change some messages and I guess this got changed with
> all the other new ones. It wasn't strictly intentional but it wasn't
> done by mistake either.
> 
>> Is the new message final, or should we just check for the "PrincipalName 
>> not found." substring?
> 
> I do not expect other changes for the near future.
> 
> Simo.
> 

In that case ACK for Petr's patch, tests were fixed.

Pushed to master: a7e400fa654c8afb44b25f0645747c200ef34e09

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 0614 test_ipagetkeytab: Fix expected error message

2014-07-03 Thread Simo Sorce
On Wed, 2014-07-02 at 18:32 +0200, Petr Viktorin wrote:
> It looks like ipa-getkeytab error message for a non-existent service 
> changed.
> 
> Simo, is this expected?

I was asked to change some messages and I guess this got changed with
all the other new ones. It wasn't strictly intentional but it wasn't
done by mistake either.

> Is the new message final, or should we just check for the "PrincipalName 
> not found." substring?

I do not expect other changes for the near future.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel