Re: [Freeipa-devel] [PATCH] 1037 optimize restoring SELinux booleans

2012-10-02 Thread Petr Viktorin
On 10/01/2012 09:29 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 10/01/2012 04:41 PM, Rob Crittenden wrote: The web uninstall step can be very long because we restore two SELinux booleans individually. This patch combines them into a single step, and skips setting them if the values won't

Re: [Freeipa-devel] [PATCH] 1037 optimize restoring SELinux booleans

2012-10-02 Thread Rob Crittenden
Petr Viktorin wrote: On 10/01/2012 09:29 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 10/01/2012 04:41 PM, Rob Crittenden wrote: The web uninstall step can be very long because we restore two SELinux booleans individually. This patch combines them into a single step, and skips setting

Re: [Freeipa-devel] [PATCH] 1037 optimize restoring SELinux booleans

2012-10-01 Thread Petr Viktorin
On 10/01/2012 04:41 PM, Rob Crittenden wrote: The web uninstall step can be very long because we restore two SELinux booleans individually. This patch combines them into a single step, and skips setting them if the values won't actually change. rob Is there a reason to not reuse the code

Re: [Freeipa-devel] [PATCH] 1037 optimize restoring SELinux booleans

2012-10-01 Thread Rob Crittenden
Petr Viktorin wrote: On 10/01/2012 04:41 PM, Rob Crittenden wrote: The web uninstall step can be very long because we restore two SELinux booleans individually. This patch combines them into a single step, and skips setting them if the values won't actually change. rob Is there a reason to