Re: [Freeipa-devel] [PATCH] 108 Better hbactest validation message

2012-03-15 Thread Petr Vobornik

On 03/14/2012 03:13 PM, Endi Sukma Dewata wrote:

On 3/12/2012 8:22 AM, Petr Vobornik wrote:

HBAC Test validation message now contains all missing values in form of
list of links instead of general 'missing values' message and
redirection to first missing value's facet.

When a link is clicked user is redirected to value's facet.

https://fedorahosted.org/freeipa/ticket/2182

Note: In a list I chose to display an option label instead of facet
label. IMHO it seems better with message 'Missing values'.


It looks good. ACK.


Pushed to master, ipa-2-2.

--
Petr Vobornik

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 108 Better hbactest validation message

2012-03-14 Thread Endi Sukma Dewata

On 3/12/2012 8:22 AM, Petr Vobornik wrote:

HBAC Test validation message now contains all missing values in form of
list of links instead of general 'missing values' message and
redirection to first missing value's facet.

When a link is clicked user is redirected to value's facet.

https://fedorahosted.org/freeipa/ticket/2182

Note: In a list I chose to display an option label instead of facet
label. IMHO it seems better with message 'Missing values'.


It looks good. ACK.

--
Endi S. Dewata

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel