Re: [Freeipa-devel] [PATCH] 140 Moved adder dialog box into entity.
On 4/21/2011 1:59 PM, Adam Young wrote: On 04/19/2011 11:19 AM, Endi Sukma Dewata wrote: On 4/18/2011 6:06 PM, Adam Young wrote: The adder dialog box definition has been moved from search facet into entity to make it available to other facets. Shouldn't it move into add.js, or should add.js go away? This patch only modifies the entity builder interface which is stored in entity.js. The adder dialog base class is still defined in add.js like before. We could merge add.js into another file, but that's a separate issue. ACK Rebased, fixed typos, and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 140 Moved adder dialog box into entity.
On 04/19/2011 11:19 AM, Endi Sukma Dewata wrote: On 4/18/2011 6:06 PM, Adam Young wrote: The adder dialog box definition has been moved from search facet into entity to make it available to other facets. Shouldn't it move into add.js, or should add.js go away? This patch only modifies the entity builder interface which is stored in entity.js. The adder dialog base class is still defined in add.js like before. We could merge add.js into another file, but that's a separate issue. ACK ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 140 Moved adder dialog box into entity.
On 4/18/2011 6:06 PM, Adam Young wrote: The adder dialog box definition has been moved from search facet into entity to make it available to other facets. Shouldn't it move into add.js, or should add.js go away? This patch only modifies the entity builder interface which is stored in entity.js. The adder dialog base class is still defined in add.js like before. We could merge add.js into another file, but that's a separate issue. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 140 Moved adder dialog box into entity.
On 04/18/2011 06:47 PM, Endi Sukma Dewata wrote: The adder dialog box definition has been moved from search facet into entity to make it available to other facets. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel Shouldn't it move into add.js, or should add.js go away? ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
