Re: [Freeipa-devel] [PATCH] 169 Fix LDAP object parameter encoding

2011-11-15 Thread Martin Kosek
On Mon, 2011-11-14 at 19:10 +0200, Alexander Bokovoy wrote: On Mon, 14 Nov 2011, Martin Kosek wrote: Tests are now OK, there were a lot of errors related to permissions and hosts (--random was always on). I was also thinking if the encoding step shouldn't be done as late as possible,

Re: [Freeipa-devel] [PATCH] 169 Fix LDAP object parameter encoding

2011-11-15 Thread Alexander Bokovoy
On Tue, 15 Nov 2011, Martin Kosek wrote: Or maybe we should document them better? Right now there is no documentation for a majority of those flags. I renamed it to 'virtual_attribute' (as an opposite to physical LDAP attribute), I hope it makes more sense. You are right that we

Re: [Freeipa-devel] [PATCH] 169 Fix LDAP object parameter encoding

2011-11-15 Thread Martin Kosek
On Tue, 2011-11-15 at 12:33 +0200, Alexander Bokovoy wrote: On Tue, 15 Nov 2011, Martin Kosek wrote: Or maybe we should document them better? Right now there is no documentation for a majority of those flags. I renamed it to 'virtual_attribute' (as an opposite to physical LDAP

Re: [Freeipa-devel] [PATCH] 169 Fix LDAP object parameter encoding

2011-11-14 Thread Alexander Bokovoy
On Mon, 14 Nov 2011, Martin Kosek wrote: Tests are now OK, there were a lot of errors related to permissions and hosts (--random was always on). I was also thinking if the encoding step shouldn't be done as late as possible, i.e. after plugin's pre_callbacks, right before LDAP is called.