Re: [Freeipa-devel] [PATCH] 172 Bigger textarea for permission type=subtree
On 07/17/2012 04:57 PM, Endi Sukma Dewata wrote:
On 7/17/2012 9:25 AM, Petr Vobornik wrote:
Possible improvement, instead of using a fixed column size the text area
also could be made to occupy 100% of available width. Ideally it should
have the same width as the text field or drop down list in this dialog.
Updated patch attached.
I added two styles:
.textarea-widget textarea {
width: 250px;
}
.facet-content .textarea-widget textarea {
width: 400px;
}
First one makes textarea width the same as text_widget - good for
dialogs.
Second one makes textareas wider in facets. IMO it is better - more
space for the text. Also previous implementation was about 330px in FF
so it isn't big difference. 400px is about the same width as ssh-key
widget and in also leaves space for possible action panel.
Looks much better. ACK.
Pushed to master.
--
Petr Vobornik
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 172 Bigger textarea for permission type=subtree
On 7/17/2012 9:25 AM, Petr Vobornik wrote:
Possible improvement, instead of using a fixed column size the text area
also could be made to occupy 100% of available width. Ideally it should
have the same width as the text field or drop down list in this dialog.
Updated patch attached.
I added two styles:
.textarea-widget textarea {
width: 250px;
}
.facet-content .textarea-widget textarea {
width: 400px;
}
First one makes textarea width the same as text_widget - good for dialogs.
Second one makes textareas wider in facets. IMO it is better - more
space for the text. Also previous implementation was about 330px in FF
so it isn't big difference. 400px is about the same width as ssh-key
widget and in also leaves space for possible action panel.
Looks much better. ACK.
--
Endi S. Dewata
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 172 Bigger textarea for permission type=subtree
On 07/17/2012 01:10 AM, Endi Sukma Dewata wrote:
On 7/16/2012 6:53 AM, Petr Vobornik wrote:
Patch description:
Adder dialog and details facet for permission type=subtree have small
textarea for defining subtree filter. It was unconfortable to define the
filter. This difference was removed.
https://fedorahosted.org/freeipa/ticket/2832
Note regarding related ticket:
Resizable textareas are browser-specific. We can do it in code too but I
don't think it is worth the effort.
Textarea in IE still seems smaller than in Firefox, but it has the same
number of rows and cols. I think it has enough space for defining the
filter so it should be fixing the problem.
ACK.
Possible improvement, instead of using a fixed column size the text area
also could be made to occupy 100% of available width. Ideally it should
have the same width as the text field or drop down list in this dialog.
Updated patch attached.
I added two styles:
.textarea-widget textarea {
width: 250px;
}
.facet-content .textarea-widget textarea {
width: 400px;
}
First one makes textarea width the same as text_widget - good for dialogs.
Second one makes textareas wider in facets. IMO it is better - more
space for the text. Also previous implementation was about 330px in FF
so it isn't big difference. 400px is about the same width as ssh-key
widget and in also leaves space for possible action panel.
--
Petr Vobornik
From 77cf857afc8d69852bc3e732c9635e2f7c503d4b Mon Sep 17 00:00:00 2001
From: Petr Vobornik
Date: Mon, 16 Jul 2012 13:40:52 +0200
Subject: [PATCH] Bigger textarea for permission type=subtree
Adder dialog and details facet for permission type=subtree have small textarea for defining subtree filter. It was unconfortable to define the filter. This difference was removed.
https://fedorahosted.org/freeipa/ticket/2832
---
install/ui/aci.js |2 --
install/ui/ipa.css |8
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/install/ui/aci.js b/install/ui/aci.js
index b2e5e19e54fe083093171d29fe894df321bb4c88..63181efac5f335d28a4c23bfa1ae2da95b9a0e75 100644
--- a/install/ui/aci.js
+++ b/install/ui/aci.js
@@ -688,8 +688,6 @@ IPA.permission_target_widget = function(spec) {
that.subtree_textarea = IPA.textarea_widget({
entity: that.entity,
name: 'subtree',
-cols: 30,
-rows: 1,
hidden: true
});
diff --git a/install/ui/ipa.css b/install/ui/ipa.css
index a3b93078b64fc057ba81271abbe093717d766149..76ce265f0f5c90404046726fe55bd54d73c9b365 100644
--- a/install/ui/ipa.css
+++ b/install/ui/ipa.css
@@ -1307,6 +1307,14 @@ table.scrollable tbody {
width: 250px;
}
+.textarea-widget textarea {
+width: 250px;
+}
+
+.facet-content .textarea-widget textarea {
+width: 400px;
+}
+
.combobox-widget-input {
display: inline-block;
position: relative;
--
1.7.10.4
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 172 Bigger textarea for permission type=subtree
On 7/16/2012 6:53 AM, Petr Vobornik wrote: Patch description: Adder dialog and details facet for permission type=subtree have small textarea for defining subtree filter. It was unconfortable to define the filter. This difference was removed. https://fedorahosted.org/freeipa/ticket/2832 Note regarding related ticket: Resizable textareas are browser-specific. We can do it in code too but I don't think it is worth the effort. Textarea in IE still seems smaller than in Firefox, but it has the same number of rows and cols. I think it has enough space for defining the filter so it should be fixing the problem. ACK. Possible improvement, instead of using a fixed column size the text area also could be made to occupy 100% of available width. Ideally it should have the same width as the text field or drop down list in this dialog. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
