Re: [Freeipa-devel] [PATCH] 205 Reflect API change of SSH store in Web UI
Endi Sukma Dewata wrote: On 9/5/2012 3:14 AM, Petr Vobornik wrote: Format of ipasshpubkey in users and hosts changed from BYTES to STR. Web UI no longer gets the value as base64 encoded string in an object. Label was changed to reflect that the key don't have to be plain base64 encoded blob. https://fedorahosted.org/freeipa/ticket/2989 Note: freeipa-jcholast-83-openssh-style-public-keys.patch should be applied ACK. Possible improvements: 1. Right now if you click 'Add' SSH public key you'd have to click 'Show/Set key' to enter the value. We probably could make it such that when you click 'Add' it will open the input dialog immediately. This way we can avoid an incomplete state where a slot for a new key is added but it's empty. 2. If we do #1 the 'New: key set/not set' label can be changed to 'New key'. The 'Modified' can be changed to 'Modified key'. 3. The 'Show/Set key' probably can be changed to 'View/Edit' to be more consistent with host/service certificate. pushed to ipa-3-0 and master rob ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 205 Reflect API change of SSH store in Web UI
On 9/5/2012 3:14 AM, Petr Vobornik wrote: Format of ipasshpubkey in users and hosts changed from BYTES to STR. Web UI no longer gets the value as base64 encoded string in an object. Label was changed to reflect that the key don't have to be plain base64 encoded blob. https://fedorahosted.org/freeipa/ticket/2989 Note: freeipa-jcholast-83-openssh-style-public-keys.patch should be applied ACK. Possible improvements: 1. Right now if you click 'Add' SSH public key you'd have to click 'Show/Set key' to enter the value. We probably could make it such that when you click 'Add' it will open the input dialog immediately. This way we can avoid an incomplete state where a slot for a new key is added but it's empty. 2. If we do #1 the 'New: key set/not set' label can be changed to 'New key'. The 'Modified' can be changed to 'Modified key'. 3. The 'Show/Set key' probably can be changed to 'View/Edit' to be more consistent with host/service certificate. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
