Re: [Freeipa-devel] [PATCH] 211 Prevent opening of multiple dirty dialogs on navigation

2012-09-12 Thread Petr Vobornik

On 09/10/2012 09:12 PM, Endi Sukma Dewata wrote:

On 9/7/2012 7:37 AM, Petr Vobornik wrote:

Facets which performs AJAX call after update refresh (clear dirty state)
after calling callback of dirty dialog. It might lead to multiple
openings of dirty dialog.

Assuming that calling dirty dialog's callback can be evaluated as "dirty
state is gone", we can call reset in the callback to prevent the issue.
There will be an incorrect state in the facet for a moment. It will be
fixed soon on execute of callback of the refresh AJAX call. It is not an
issue because it will happen in background. User will be looking on
different facet.

https://fedorahosted.org/freeipa/ticket/2667


ACK.


Pushed to master, ipa-3-0.

--
Petr Vobornik

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 211 Prevent opening of multiple dirty dialogs on navigation

2012-09-10 Thread Endi Sukma Dewata

On 9/7/2012 7:37 AM, Petr Vobornik wrote:

Facets which performs AJAX call after update refresh (clear dirty state)
after calling callback of dirty dialog. It might lead to multiple
openings of dirty dialog.

Assuming that calling dirty dialog's callback can be evaluated as "dirty
state is gone", we can call reset in the callback to prevent the issue.
There will be an incorrect state in the facet for a moment. It will be
fixed soon on execute of callback of the refresh AJAX call. It is not an
issue because it will happen in background. User will be looking on
different facet.

https://fedorahosted.org/freeipa/ticket/2667


ACK.

--
Endi S. Dewata

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel