Re: [Freeipa-devel] [PATCH] 214 Fixed problem loading data in HBAC/sudo details page.

2011-07-21 Thread Endi Sukma Dewata

On 7/21/2011 10:25 AM, Adam Young wrote:

On 07/21/2011 10:27 AM, Endi Sukma Dewata wrote:

On 7/21/2011 9:23 AM, Endi Sukma Dewata wrote:

In a recent change the details page was changed to create and locate
field containers with 'details-field' CSS class. The HBAC and sudo
custom details pages have been modified to use the same CSS class.

Ticket #1508

Patch attached.



ACK


Pushed to master.

--
Endi S. Dewata

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 214 Fixed problem loading data in HBAC/sudo details page.

2011-07-21 Thread Adam Young

On 07/21/2011 10:27 AM, Endi Sukma Dewata wrote:

On 7/21/2011 9:23 AM, Endi Sukma Dewata wrote:

In a recent change the details page was changed to create and locate
field containers with 'details-field' CSS class. The HBAC and sudo
custom details pages have been modified to use the same CSS class.

Ticket #1508



Patch attached.


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

ACK
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 214 Fixed problem loading data in HBAC/sudo details page.

2011-07-21 Thread Endi Sukma Dewata

On 7/21/2011 9:23 AM, Endi Sukma Dewata wrote:

In a recent change the details page was changed to create and locate
field containers with 'details-field' CSS class. The HBAC and sudo
custom details pages have been modified to use the same CSS class.

Ticket #1508



Patch attached.

--
Endi S. Dewata
From 2e484044b0a281d7493f2545810f9a7b2579333a Mon Sep 17 00:00:00 2001
From: Endi S. Dewata 
Date: Thu, 21 Jul 2011 09:07:23 -0500
Subject: [PATCH] Fixed problem loading data in HBAC/sudo details page.

In a recent change the details page was changed to create and locate
field containers with 'details-field' CSS class. The HBAC and sudo
custom details pages have been modified to use the same CSS class.

Ticket #1508
---
 install/ui/hbac.js |   27 +--
 install/ui/rule.js |6 --
 install/ui/sudo.js |   39 ++-
 3 files changed, 51 insertions(+), 21 deletions(-)

diff --git a/install/ui/hbac.js b/install/ui/hbac.js
index d7c0b94622d678ca6315e8ebac04c5ce2aefc136..387c03cee0f76933f307a8a92130a4022a327e8e 100644
--- a/install/ui/hbac.js
+++ b/install/ui/hbac.js
@@ -578,7 +578,10 @@ IPA.hbacrule_details_general_section = function(spec) {
 td = $('').appendTo(tr);
 
 var field = that.get_field('cn');
-var span = $('', { 'name': 'cn' }).appendTo(td);
+var span = $('', {
+name: 'cn',
+'class': 'details-field'
+}).appendTo(td);
 
 $('', {
 name: 'cn',
@@ -603,7 +606,10 @@ IPA.hbacrule_details_general_section = function(spec) {
 td.append(param_info.label+':');
 
 field = that.get_field('accessruletype');
-span = $('', { 'name': 'accessruletype' }).appendTo(td);
+span = $('', {
+name: 'accessruletype',
+'class': 'details-field'
+}).appendTo(td);
 
 $('', {
 'type': 'radio',
@@ -645,7 +651,10 @@ IPA.hbacrule_details_general_section = function(spec) {
 }).appendTo(tr);
 
 field = that.get_field('description');
-span = $('', { 'name': 'description' }).appendTo(td);
+span = $('', {
+name: 'description',
+'class': 'details-field'
+}).appendTo(td);
 
 $('', {
 'name': 'description',
@@ -670,7 +679,10 @@ IPA.hbacrule_details_general_section = function(spec) {
 }).appendTo(tr);
 
 field = that.get_field('ipaenabledflag');
-span = $('', { 'name': 'ipaenabledflag' }).appendTo(td);
+span = $('', {
+name: 'ipaenabledflag',
+'class': 'details-field'
+}).appendTo(td);
 
 $('', {
 'type': 'radio',
@@ -757,7 +769,10 @@ IPA.hbacrule_accesstime_widget = function(spec) {
 
 container.append('');
 
-span = $('', { 'name': 'table' }).appendTo(container);
+span = $('', {
+name: 'table',
+'class': 'details-field'
+}).appendTo(container);
 
 that.table.create(span);
 
@@ -780,7 +795,7 @@ IPA.hbacrule_accesstime_widget = function(spec) {
 
 that.widget_setup(container);
 
-var span = $('span[name="table"]', that.container);
+var span = $('.details-field[name="table"]', that.container);
 that.table.setup(span);
 
 var button = $('input[name=remove]', span);
diff --git a/install/ui/rule.js b/install/ui/rule.js
index 106b870bbc1767c685e6da158bc141b6f80a8a71..aec86574f023a7e49b8e997de2e46a40e9eaa08e 100644
--- a/install/ui/rule.js
+++ b/install/ui/rule.js
@@ -45,7 +45,8 @@ IPA.rule_details_section = function(spec) {
 
 var span = $('', {
 name: that.field_name,
-title: param_info.doc
+title: param_info.doc,
+'class': 'details-field'
 }).appendTo(container);
 
 if (that.options.length) {
@@ -77,7 +78,8 @@ IPA.rule_details_section = function(spec) {
 
 var table_span = $('', {
 name: table.field_name,
-title: param_info ? param_info.doc : table.field_name
+title: param_info ? param_info.doc : table.field_name,
+'class': 'details-field'
 }).appendTo(span);
 
 field = that.get_field(table.field_name);
diff --git a/install/ui/sudo.js b/install/ui/sudo.js
index efa5a955ebc1ad9d2a69c7c4beb894ea19f0a75b..fecb0b070c3889470846d12080aca040df42ee08 100644
--- a/install/ui/sudo.js
+++ b/install/ui/sudo.js
@@ -787,7 +787,8 @@ IPA.sudo.rule_details_general_section = function(spec) {
 
 var span = $('', {
 name: 'cn',
-title: param_info ? param_info.doc : 'cn'
+title: param_info ? param_info.doc : 'cn',
+'class': 'details-field'
 }).appendTo(td);
 
 $('', {
@@ -821,7 +822,8 @@ IPA.sudo.rule_details_general_section = function(spec) {
 
 span = $('', {
 name: 'description',
-title: param_info ? para