Re: [Freeipa-devel] [PATCH] 216 Remove memberPrincipal for deleted replicas

2012-03-02 Thread Simo Sorce
On Fri, 2012-03-02 at 12:34 +0100, Martin Kosek wrote: +principals.remove(member_principal) +mod = [(ldap.MOD_REPLACE, 'memberPrincipal', principals)] Any special reason why you use a search and then a replace instead of a delete by value ? A delete by value

Re: [Freeipa-devel] [PATCH] 216 Remove memberPrincipal for deleted replicas

2012-03-02 Thread Martin Kosek
On Fri, 2012-03-02 at 09:39 -0500, Simo Sorce wrote: On Fri, 2012-03-02 at 12:34 +0100, Martin Kosek wrote: +principals.remove(member_principal) +mod = [(ldap.MOD_REPLACE, 'memberPrincipal', principals)] Any special reason why you use a search and then a

Re: [Freeipa-devel] [PATCH] 216 Remove memberPrincipal for deleted replicas

2012-03-02 Thread Simo Sorce
On Fri, 2012-03-02 at 16:22 +0100, Martin Kosek wrote: On Fri, 2012-03-02 at 09:39 -0500, Simo Sorce wrote: On Fri, 2012-03-02 at 12:34 +0100, Martin Kosek wrote: +principals.remove(member_principal) +mod = [(ldap.MOD_REPLACE, 'memberPrincipal',

Re: [Freeipa-devel] [PATCH] 216 Remove memberPrincipal for deleted replicas

2012-03-02 Thread Martin Kosek
On Fri, 2012-03-02 at 10:30 -0500, Simo Sorce wrote: On Fri, 2012-03-02 at 16:22 +0100, Martin Kosek wrote: On Fri, 2012-03-02 at 09:39 -0500, Simo Sorce wrote: On Fri, 2012-03-02 at 12:34 +0100, Martin Kosek wrote: +principals.remove(member_principal) +