Re: [Freeipa-devel] [PATCH] 242 Removed custom layout for password reset.

2011-08-18 Thread Simo Sorce
On Tue, 2011-08-16 at 16:13 -0500, Endi Sukma Dewata wrote:
 On 8/15/2011 10:44 AM, Petr Vobornik wrote:
  On 08/11/2011 07:44 PM, Endi Sukma Dewata wrote:
  The dialog box for resetting user password has been modified to use
  the standard layout.
 
  patch from code and working perspective is OK.
 
  Has this patch assigned some ticket? Don't know exactly what is IPA's
  policy for submitting patches without tickets in Trac (for future
  tracking).
 
 I attached the patch into this ticket:
 https://fedorahosted.org/freeipa/ticket/1641
 We'll push it when we start working on 3.0 stuff.

Have you pushed this one ?
The master branch now is 3.0 material :)

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 242 Removed custom layout for password reset.

2011-08-18 Thread Endi Sukma Dewata

On 8/18/2011 10:03 AM, Simo Sorce wrote:

On Tue, 2011-08-16 at 16:13 -0500, Endi Sukma Dewata wrote:

On 8/15/2011 10:44 AM, Petr Vobornik wrote:

On 08/11/2011 07:44 PM, Endi Sukma Dewata wrote:

The dialog box for resetting user password has been modified to use
the standard layout.



patch from code and working perspective is OK.



Has this patch assigned some ticket? Don't know exactly what is IPA's
policy for submitting patches without tickets in Trac (for future
tracking).


I attached the patch into this ticket:
https://fedorahosted.org/freeipa/ticket/1641
We'll push it when we start working on 3.0 stuff.


Have you pushed this one ?
The master branch now is 3.0 material :)


OK, I pushed this to master and ipa-2-1 because it's only a cleanup, not 
a new functionality, also minimizing diverging branch.


--
Endi S. Dewata

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 242 Removed custom layout for password reset.

2011-08-16 Thread Endi Sukma Dewata

On 8/15/2011 10:44 AM, Petr Vobornik wrote:

On 08/11/2011 07:44 PM, Endi Sukma Dewata wrote:

The dialog box for resetting user password has been modified to use
the standard layout.



patch from code and working perspective is OK.



Has this patch assigned some ticket? Don't know exactly what is IPA's
policy for submitting patches without tickets in Trac (for future
tracking).


I attached the patch into this ticket:
https://fedorahosted.org/freeipa/ticket/1641
We'll push it when we start working on 3.0 stuff.

--
Endi S. Dewata

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 242 Removed custom layout for password reset.

2011-08-15 Thread Petr Vobornik

On 08/11/2011 07:44 PM, Endi Sukma Dewata wrote:

The dialog box for resetting user password has been modified to use
the standard layout.



___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

patch from code and working perspective is OK.

Has this patch assigned some ticket? Don't know exactly what is IPA's 
policy for submitting patches without tickets in Trac (for future tracking).


--
Petr Vobornik

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 242 Removed custom layout for password reset.

2011-08-15 Thread Dmitri Pal
On 08/15/2011 11:44 AM, Petr Vobornik wrote:
 On 08/11/2011 07:44 PM, Endi Sukma Dewata wrote:
 The dialog box for resetting user password has been modified to use
 the standard layout.



 ___
 Freeipa-devel mailing list
 Freeipa-devel@redhat.com
 https://www.redhat.com/mailman/listinfo/freeipa-devel
 patch from code and working perspective is OK.

 Has this patch assigned some ticket? Don't know exactly what is IPA's
 policy for submitting patches without tickets in Trac (for future
 tracking).


I would prefer to have a ticket.

-- 
Thank you,
Dmitri Pal

Sr. Engineering Manager IPA project,
Red Hat Inc.


---
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/



___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 242 Removed custom layout for password reset.

2011-08-15 Thread Endi Sukma Dewata

On 8/15/2011 11:01 AM, Dmitri Pal wrote:

patch from code and working perspective is OK.

Has this patch assigned some ticket? Don't know exactly what is IPA's
policy for submitting patches without tickets in Trac (for future
tracking).


I would prefer to have a ticket.


OK, I'll open a ticket for this. Usually it's part of a clean up process 
or needed for subsequent bug fixing.


--
Endi S. Dewata

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 242 Removed custom layout for password reset.

2011-08-15 Thread Dmitri Pal
On 08/15/2011 12:29 PM, Endi Sukma Dewata wrote:
 On 8/15/2011 11:01 AM, Dmitri Pal wrote:
 patch from code and working perspective is OK.

 Has this patch assigned some ticket? Don't know exactly what is IPA's
 policy for submitting patches without tickets in Trac (for future
 tracking).

 I would prefer to have a ticket.

 OK, I'll open a ticket for this. Usually it's part of a clean up
 process or needed for subsequent bug fixing.

Which means that there should be a ticket for the cleanup effort that
encompasses several patches.

-- 
Thank you,
Dmitri Pal

Sr. Engineering Manager IPA project,
Red Hat Inc.


---
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/



___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel