Re: [Freeipa-devel] [PATCH] 256-258 Web UI: removed build dependency errors

2013-02-21 Thread Petr Vobornik

On 02/19/2013 04:12 AM, Endi Sukma Dewata wrote:

ACK.


Pushed to master, ipa-3-1

--
Petr Vobornik

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 256-258 Web UI: removed build dependency errors

2013-02-18 Thread Endi Sukma Dewata

ACK.

--
Endi S. Dewata

On 2/18/2013 10:29 AM, Petr Vobornik wrote:

First patch adds just a devel tool usable in browser. Second is
foundation for specifying which dependency errors can be ignored in Web
UI build. Third is an usage of second.

These patches were develop as part of ongoing refactoring work but they
are independent and beneficial for all UI work so I'm sending them now.

1) [PATCH] Develop.js extended

Develop.js contains code useful only for debugging. It is not part of
FreeIPA release.

Is loaded by typing require(['freeipa/develop']); in browser JS console.
It adds IPA global variable and provide easier way of loading AMD
modules into window.ipadev[providedNameOrModuleName] variable.


2) [PATCH] Allow to specify modules for which builder doesn't raise
  dependency error

One can specify module ids provided by other means (already built layer
file) in providedMids array of build profile file's package section.
Builder then ignores dependency errors for specified modules. This
allows to build layers without source codes of their dependencies, with
no expected errors raised.

Example:

packages:[
 {
 name: freeipa,
 location: freeipa,
 providedMids: [
 'dojo/_base/declare',
 'dojo/_base/lang',
 'dojo/_base/array',
 'dojo/Stateful'
 //etc
 ]
 }
],

[PATCH] Web UI build profile updated

freeipa.profile was updated accordingly to contain all modules in dojo
layer.

This change removes expected errors during the build and therefore it
won't confuse others during rpm build. It also helps during development
because developer will notice real dependency errors (those not
specified this way).


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel