Re: [Freeipa-devel] [PATCH] 303 Fixed inconsistent details facet validation.

2011-10-27 Thread Petr Vobornik
On 10/27/2011 01:39 AM, Endi Sukma Dewata wrote: The details facet validation has been moved out of update() such that all subclasses perform consistent validation. Ticket #1455 ACK with a small doubt. I'm not sure if moving the validation call to update button's click handler is the right

Re: [Freeipa-devel] [PATCH] 303 Fixed inconsistent details facet validation.

2011-10-27 Thread Endi Sukma Dewata
On 10/27/2011 4:29 AM, Petr Vobornik wrote: ACK with a small doubt. I'm not sure if moving the validation call to update button's click handler is the right move. I think, this way the handler is doing more things than it should do. However I'm fond of changing the update method to be more